Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEVM-fix: fix journal record in add/sub balance with 0 #248

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

sunny2022da
Copy link
Collaborator

Description

add a description of your changes here...

Rationale

tell us why we need these changes...

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@github-actions github-actions bot requested review from bnoieh and krish-nr January 9, 2025 03:19
@sunny2022da sunny2022da requested review from welkin22 and removed request for krish-nr and bnoieh January 9, 2025 03:19
Copy link
Contributor

@andyzhang2023 andyzhang2023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@welkin22
Copy link
Contributor

welkin22 commented Jan 9, 2025

It seems the Unit Test did not pass, please fix it.

@sunny2022da sunny2022da merged commit e109b4e into bnb-chain:feature/TxDAG-PEVM Jan 9, 2025
1 of 2 checks passed
@sunny2022da
Copy link
Collaborator Author

This PR is merged by accident. will revert it and redo.

@sunny2022da
Copy link
Collaborator Author

#249 is created to cover this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants