PEVM-fix: fix journal record in add/sub balance with 0

bnb-chain · Jan 9, 2025 · e109b4e · e109b4e
1 parent 9c30172
commit e109b4e
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/core/state/pevm_statedb.go b/core/state/pevm_statedb.go
@@ -169,15 +169,25 @@ func (pst *UncommittedDB) Prepare(rules params.Rules, sender, coinbase common.Ad
 //  2. object
 
 func (pst *UncommittedDB) SubBalance(addr common.Address, amount *uint256.Int) {
-	pst.journal.append(newJBalance(pst.cache[addr], addr))
 	obj := pst.getOrNewObject(addr)
+	if amount.IsZero() {
+		if !obj.empty(pst) {
+			return
+		}
+	}
+	pst.journal.append(newJBalance(pst.cache[addr], addr))
 	newb := new(uint256.Int).Sub(obj.balance, amount)
 	pst.cache.setBalance(addr, newb)
 }
 
 func (pst *UncommittedDB) AddBalance(addr common.Address, amount *uint256.Int) {
-	pst.journal.append(newJBalance(pst.cache[addr], addr))
 	obj := pst.getOrNewObject(addr)
+	if amount.IsZero() {
+		if !obj.empty(pst) {
+			return
+		}
+	}
+	pst.journal.append(newJBalance(pst.cache[addr], addr))
 	newb := new(uint256.Int).Add(obj.balance, amount)
 	pst.cache.setBalance(addr, newb)
 }