quick fixes #153
Merged
quick fixes #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11132933430Details
💛 - Coveralls |
antgonza
reviewed
Sep 19, 2024
sequence_processing_pipeline/Job.py
Outdated
| @@ -257,6 +260,8 @@ def query_slurm(job_ids): | |||
| jobs = {} | |||
| child_jobs = {} | |||
| for job_id, unique_id, state in lines: | |||
| # ensure unique_id is of type string for downstream use. | |||
| unique_id = str(unique_id) | |||
There was a problem hiding this comment.
Is this actually possible? I mean, lines is an array of strings (x.split).
| @@ -226,6 +226,9 @@ def wait_on_job_ids(self, job_ids, callback=None): | |||
| # them before returning, optionally submitting callbacks for each | |||
| # job-id. | |||
|
|
|||
| # ensure all ids are strings to ensure proper working w/join(). | |||
| job_ids = [str(x) for x in job_ids] | |||
There was a problem hiding this comment.
What edge case caused problems here?
There was a problem hiding this comment.
I once passed in a list of job-ids that had been converted to int()s in the process of error checking and it made the entire job fail because of a downstream str.join(). IMHO this is prudent as there's nothing else checking the input parameters for this method and this kind of error is the kind that can be hard to debug for some down the road. Moreover because it uses a list comprehension it should be pretty cheap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.