Fix calculation of skybox rotation

[hukasu]

Objective

Fixes #16628

Solution

Matrices were being applied in the wrong order.

Testing

Ran skybox example with rotations applied to the Skybox on the x, y, and z axis (one at a time).

e.g.

Skybox {
    image: skybox_handle.clone(),
    brightness: 1000.0,
    rotation: Quat::from_rotation_y(-45.0_f32.to_radians()),
}

Showcase

Screencast_20250121_151232.webm

[mate-h]

Looks good to me, I also noticed this issue in main while trying to align a skybox and directional light. Thanks for fixing.

[greeble-dev]

Changes seem good and I've tested with the skybox example. But left a suggestion to update comments and variable names.

[greeble-dev]

I think the comments and variable names are now misleading? Should be something like:

Suggested change

	// Transforming the view space ray direction by the skybox transform matrix, it is
	// equivalent to rotating the skybox itself.
	var view_ray_direction = view_position_homogeneous.xyz / view_position_homogeneous.w;
	view_ray_direction = (uniforms.transform * vec4(view_ray_direction, 1.0)).xyz;
	view_ray_direction = (view.world_from_view * vec4(view_ray_direction, 0.0)).xyz;
	// Transforming the view space ray direction by the view matrix, transforms the
	// direction to world space. Note that the w element is set to 0.0, as this is a
	// vector direction, not a position, That causes the matrix multiplication to ignore
	// the translations from the view matrix.
	let ray_direction = (view.world_from_view * vec4(view_ray_direction, 0.0)).xyz;
	let ray_direction = (uniforms.transform * vec4(view_ray_direction, 0.0)).xyz;
	// Transforming the view space ray direction by the view matrix, transforms the
	// direction to world space. Note that the w element is set to 0.0, as this is a
	// vector direction, not a position, That causes the matrix multiplication to ignore
	// the translations from the view matrix.
	let view_ray_direction = view_position_homogeneous.xyz / view_position_homogeneous.w;
	let world_ray_direction = (view.world_from_view * vec4(view_ray_direction, 0.0)).xyz;
	// Transforming the world space ray direction by the skybox transform matrix, it is
	// equivalent to rotating the skybox itself.
	let ray_direction = (uniforms.transform * vec4(world_ray_direction, 0.0)).xyz;