Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

25147 - Changed the redirection link of the new BRD #3197

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

JazzarKarim
Copy link
Collaborator

@JazzarKarim JazzarKarim commented Jan 6, 2025

Issue #:
bcgov/entity#25147

Description of changes:

screen-capture.webm

Will open the PR in business-ui shortly.

PLEASE DON'T MERGE THIS BEFORE I MERGE THE PR IN business-ui Can be merged now.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

@JazzarKarim JazzarKarim force-pushed the 25147-fix-staff-redirection branch from 9088729 to b3afd2d Compare January 8, 2025 20:01
@JazzarKarim
Copy link
Collaborator Author

/gcbrun

Copy link

sonarqubecloud bot commented Jan 8, 2025

@bcregistry-sre
Copy link
Collaborator

bcregistry-sre commented Jan 8, 2025

Temporary Url for review: https://bcregistry-account-dev--pr-3197-3njovjll.web.app

https://bcregistry-account-dev--pr-3197-3njovjll.web.app/staff/dashboard/active

Try choosing any account while logged in as staff.

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Jan 8, 2025

Temporary Url for review: https://bcregistry-account-dev--pr-3197-3njovjll.web.app

https://bcregistry-account-dev--pr-3197-3njovjll.web.app/staff/dashboard/active

Try choosing any account while logged in as staff.

I just tested this, and clicked on My Staff Business Registry, and saw the 404 page quickly.

This reproduces every time:

image

and then

image

@JazzarKarim
Copy link
Collaborator Author

Temporary Url for review: https://bcregistry-account-dev--pr-3197-3njovjll.web.app
https://bcregistry-account-dev--pr-3197-3njovjll.web.app/staff/dashboard/active
Try choosing any account while logged in as staff.

I just tested this, and clicked on My Staff Business Registry, and saw the 404 page quickly.

This reproduces every time:

image

and then

image

Are you logged in as staff? Is there something specific that's getting you to see it? I've tried lots of stuff and I can't seem to see it on my side 😢 I'm trying to reproduce so that I can fix this (I thought my slug fix works as I stopped seeing it).

Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with this for now. Merge when ready,

@JazzarKarim JazzarKarim merged commit acc0a52 into bcgov:main Jan 8, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants