Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed staff account id redirection #45

Merged
merged 13 commits into from
Jan 8, 2025

Conversation

JazzarKarim
Copy link
Collaborator

bcgov/entity#25147

This will need to be merged before bcgov/sbc-auth#3197

@JazzarKarim JazzarKarim self-assigned this Jan 7, 2025
@bcgov bcgov deleted a comment from bcregistry-sre Jan 7, 2025
@JazzarKarim
Copy link
Collaborator Author

/gcbrun

@bcgov bcgov deleted a comment from bcregistry-sre Jan 7, 2025
@bcregistry-sre
Copy link
Collaborator

bcregistry-sre commented Jan 7, 2025

Temporary Url for review: https://business-registry-dev--pr-45-0ckuok3v.web.app

https://business-registry-dev--pr-45-0ckuok3v.web.app/account/2288
https://business-registry-dev--pr-45-0ckuok3v.web.app/account/3040
etc etc

These links, if you're staff, you'll be seeing different tables. If you're a regular user however, you'll always see the current account's affiliations (the account you're logged in as entries).

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Jan 8, 2025

So, where are we at? Are you still working on something in here? Or does it work well enough for now? I'd like to test this further tomorrow. tested today and it works as expected

PS We also need to open up the BRD FF to act like the old MBR. I'll do this once this is deployed to Dev

Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve these changes with the limitations discussed in the conversations.

We'll have to review this once the BRD gets its proper bcregistry domain but that's a future problem.

@JazzarKarim
Copy link
Collaborator Author

So, where are we at? Are you still working on something in here? Or does it work well enough for now? I'd like to test this further tomorrow.

PS We also need to open up the BRD FF to act like the old MBR.

I approve these changes with the limitations discussed in the conversations.

We'll have to review this once the BRD gets its proper bcregistry domain but that's a future problem.

We should be good for now except for that one scenario. I'm going to TEST now again ALL the scenarios before merging Sev. If things look good, I'll merge. Thanks!

@JazzarKarim
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-registry-dev--pr-45-0ckuok3v.web.app

@bcgov bcgov deleted a comment from bcregistry-sre Jan 8, 2025
@JazzarKarim JazzarKarim merged commit 13897c7 into bcgov:main Jan 8, 2025
9 of 10 checks passed
@@ -0,0 +1,10 @@
<script setup lang="ts">
// This is a catch-all route that will handle any undefined routes
// This will handle the intermittent page 404 not found until the middleware is loaded
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is slug? 🐌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants