-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed staff account id redirection #45
fix: fixed staff account id redirection #45
Conversation
/gcbrun |
Temporary Url for review: https://business-registry-dev--pr-45-0ckuok3v.web.app https://business-registry-dev--pr-45-0ckuok3v.web.app/account/2288 These links, if you're staff, you'll be seeing different tables. If you're a regular user however, you'll always see the current account's affiliations (the account you're logged in as entries). |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve these changes with the limitations discussed in the conversations.
We'll have to review this once the BRD gets its proper bcregistry domain but that's a future problem.
We should be good for now except for that one scenario. I'm going to TEST now again ALL the scenarios before merging Sev. If things look good, I'll merge. Thanks! |
/gcbrun |
Temporary Url for review: https://business-registry-dev--pr-45-0ckuok3v.web.app |
@@ -0,0 +1,10 @@ | |||
<script setup lang="ts"> | |||
// This is a catch-all route that will handle any undefined routes | |||
// This will handle the intermittent page 404 not found until the middleware is loaded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is slug? 🐌
bcgov/entity#25147
This will need to be merged before bcgov/sbc-auth#3197