Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRS Configurations and Minor Text Updates #2044

Merged
merged 2 commits into from
Oct 22, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ppr-ui/devops/vaults.env
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ VUE_APP_BCOL_STAFF_PARTY_CODE="op://ppr/$APP_ENV/ppr-ui/BCOL_STAFF_PARTY_CODE"
#vaults web-url
VUE_APP_REGISTRY_URL="op://web-url/$APP_ENV/registry/REGISTRY_URL"
VUE_APP_AUTH_WEB_URL="op://web-url/$APP_ENV/auth-web/AUTH_WEB_URL"
VUE_APP_DOCUMENTS_UI_URL="op://web-url/$APP_ENV/documents-ui/DOCUMENTS_UI_URL"
VUE_APP_SITEMINDER_LOGOUT_URL="op://web-url/$APP_ENV/siteminder/SITEMINDER_LOGOUT_URL"

#vaults API
Expand All @@ -24,6 +25,9 @@ VUE_APP_MHR_API_KEY="op://API/$APP_ENV/ppr-api/MHR_API_KEY"
VUE_APP_LTSA_API_URL="op://API/$APP_ENV/ltsa-api/LTSA_API_URL"
VUE_APP_LTSA_API_VERSION="op://API/$APP_ENV/ltsa-api/LTSA_API_VERSION"
VUE_APP_LTSA_API_KEY="op://API/$APP_ENV/ltsa-api/LTSA_API_KEY"
VUE_APP_DOC_API_URL="op://API/$APP_ENV/doc-api/DOC_API_URL"
VUE_APP_DOC_API_VERSION="op://API/$APP_ENV/doc-api/DOC_API_VERSION"
VUE_APP_DOC_API_KEY="op://API/$APP_ENV/doc-api/DOC_API_KEY"
VUE_APP_AUTH_API_URL="op://API/$APP_ENV/auth-api/AUTH_API_URL"
VUE_APP_AUTH_API_VERSION="op://API/$APP_ENV/auth-api/AUTH_API_VERSION"
VUE_APP_STATUS_API_URL="op://API/$APP_ENV/status-api/STATUS_API_URL"
Expand Down
4 changes: 2 additions & 2 deletions ppr-ui/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ppr-ui/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ppr-ui",
"version": "3.2.66",
"version": "3.2.67",
"private": true,
"appName": "Assets UI",
"sbcName": "SBC Common Components",
Expand Down
2 changes: 1 addition & 1 deletion ppr-ui/src/components/mhrTransfers/TransferDetails.vue
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
class="pl-3"
>
<p>
Is the manufactured home located on land that the
Will the manufactured home be located on land that the
{{ isNewHomeOwner ? 'new' : '' }} homeowners own or on land that
they have a registered lease of 3 years or more?
</p>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
A certificate or confirmation in electronic format that confirms that no
property taxes are unpaid. Reference Manufactured Home Act sections 25 and 26(2).
</v-tooltip></strong>
showing that all local taxes for the current year have been paid is required for
showing that all local taxes for the current year have been paid is required in most cases for
manufactured homes that:
<ol
type="a"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
A certificate or confirmation in electronic format that confirms that no
property taxes are unpaid. Reference Manufactured Home Act sections 25 and 26(2).
</v-tooltip></strong>
showing that all local taxes for the current year have been paid is required for
showing that all local taxes for the current year have been paid is required in most cases for
manufactured homes that:
<ol
type="a"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@
:class="{ 'border-error-left': state.isLandOwnershipInvalid }"
:validate="state.isLandOwnershipInvalid"
:content="{
description: 'Is the manufactured home located on land that the homeowners ' +
description: 'Will the manufactured home be located on land that the homeowners ' +
'own or on land that they have a registered lease of 3 years or more?'
}"
:updatedBadge="isAmendLocationActive ? state.amendedBadgeHomeLandOwnership : null"
Expand Down
2 changes: 1 addition & 1 deletion ppr-ui/src/views/newMhrRegistration/HomeLocation.vue
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
:validate="validateLandDetails"
:class="{ 'border-error-left': validateLandDetails }"
:content="{
description: 'Is the manufactured home located on land that the homeowners own or on ' +
description: 'Will the manufactured home be located on land that the homeowners own or on ' +
'land that they have a registered lease of 3 years or more?'
}"
:updatedBadge="(isMhrCorrection || isMhrReRegistration) ? correctionState.landDetails : null"
Expand Down
2 changes: 1 addition & 1 deletion ppr-ui/tests/unit/MhrTransportPermit.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ describe('MhrTransportPermit', () => {
expect(locationChange.findComponent(TaxCertificate).exists()).toBe(true)

const homeLandOwnershipText = locationChange.findComponent(HomeLandOwnership).text()
expect(homeLandOwnershipText).toContain('Is the manufactured home')
expect(homeLandOwnershipText).toContain('Will the manufactured home')
})

it('should render all validation errors', async () => {
Expand Down
Loading