Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRS Configurations and Minor Text Updates #2044

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

cameron-eyds
Copy link
Collaborator

@cameron-eyds cameron-eyds commented Oct 21, 2024

Issue #: /bcgov/entity#23442

Description of changes:

  • Add DRS configs to the vaults
  • Minor text content updates as per QA
  • Fixes QS Dealer/MF name match condition bug
Screenshot 2024-10-22 at 12 28 31 PM

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

@cameron-eyds cameron-eyds self-assigned this Oct 21, 2024
Copy link
Collaborator

@doug-lovett doug-lovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@bcgov bcgov deleted a comment from bcregistry-sre Oct 22, 2024
@cameron-eyds
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-2044-4xm7tw08.web.app

@cameron-eyds cameron-eyds merged commit 9a0f8ea into bcgov:main Oct 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants