-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mhr summary page remove alert bar #1629
mhr summary page remove alert bar #1629
Conversation
@@ -587,9 +591,7 @@ export default defineComponent({ | |||
alertMsg: computed((): string => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The prop name should be updated, since there is no more message but only the date.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modified
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't see it modified.
Temporary Url for review: https://bcregistry-assets-dev--pr-1629-zfnd2uav.web.app |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1629 +/- ##
==========================================
+ Coverage 72.35% 77.21% +4.86%
==========================================
Files 307 381 +74
Lines 12767 7054 -5713
Branches 2630 1130 -1500
==========================================
- Hits 9237 5447 -3790
+ Misses 3518 1575 -1943
- Partials 12 32 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/gcbrun |
Temporary Url for review: https://bcregistry-assets-dev--pr-1629-zfnd2uav.web.app |
@@ -587,9 +591,7 @@ export default defineComponent({ | |||
alertMsg: computed((): string => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't see it modified.
@RuoxuanPengBC looks good, just minor comment. |
@dimak1 Regarding the 'alertMsg', alert bar still exists in other scenario, but no longer exists in residential exemptions. So I created a new variable called exemptDate to replace part of alertMsg. |
@RuoxuanPengBC thanks for clarification, i see it now 👍🏻 |
937ddfc
to
9826c11
Compare
9826c11
to
093b20c
Compare
Issue #: /bcgov/entity#18341
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).