mhr summary page remove alert bar (#1629)

* MHR summary page remove alert bar when exempted * update test to align new design - no alert msg with residential exemption
bcgov · Nov 24, 2023 · 0f137f5 · 0f137f5
1 parent 786b23a
commit 0f137f5
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 16 deletions.
diff --git a/ppr-ui/package.json b/ppr-ui/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ppr-ui",
-  "version": "2.1.24",
+  "version": "2.1.25",
   "private": true,
   "appName": "Assets UI",
   "sbcName": "SBC Common Components",

diff --git a/ppr-ui/src/resources/unitNotes.ts b/ppr-ui/src/resources/unitNotes.ts
@@ -28,8 +28,7 @@ export const NoticeOfTaxSaleDropDown: Array<UnitNoteDocTypes> = [
 
 // Dropdown items for Staff when Mhr has Residential Exemption note
 export const ResidentialExemptionStaffDropDown: Array<UnitNoteDocTypes> = [
-  UnitNoteDocTypes.PUBLIC_NOTE,
-  UnitNoteDocTypes.CONFIDENTIAL_NOTE
+  UnitNoteDocTypes.PUBLIC_NOTE
 ]
 
 // Dropdown items for QS when Mhr has Residential Exemption note

diff --git a/ppr-ui/src/views/mhrInformation/MhrInformation.vue b/ppr-ui/src/views/mhrInformation/MhrInformation.vue
@@ -41,7 +41,7 @@
                 <LienAlert v-if="hasLien" @isLoading="loading = $event" />
 
                 <template v-if="!isReviewMode">
-                  <p class="mt-7">
+                  <p v-if="!hasActiveExemption" class="mt-7">
                     This is the current information for this registration as of
                     <span class="font-weight-bold">{{ asOfDateTime }}</span>.
                   </p>
@@ -51,6 +51,10 @@
                   </p>
 
                   <!-- Unit Note Info -->
+                  <p v-if="hasActiveExemption" class="mt-7">
+                    This manufactured home is exempt as of <b>{{ exemptDate }}</b> and changes can no longer be
+                    made to this home unless the exemption is rescinded.
+                  </p>
                   <p v-if="getMhrUnitNotes && getMhrUnitNotes.length >= 1">
                     There are Unit Notes attached to this manufactured home.
                     <span v-if="isRoleStaffReg">
@@ -61,7 +65,7 @@
                     </span>
 
                     <!-- Has Alert Message (Notice of Tax Sale, and others) -->
-                    <template v-if="hasAlertMsg || hasActiveExemption">
+                    <template v-if="hasAlertMsg">
                       <CautionBox
                         class="mt-9"
                         :setMsg="alertMsg"
@@ -583,14 +587,13 @@ export default defineComponent({
       isJestRunning: computed((): boolean => {
         return process.env.JEST_WORKER_ID !== undefined
       }),
-      hasAlertMsg: false,
-      alertMsg: computed((): string => {
-        // msg when MHR has a Residential Exemption
+      exemptDate: computed((): string => {
         if (localState.hasActiveExemption) {
-          return isRoleStaffReg.value
-            ? `This manufactured home is exempt as of ${pacificDate(getActiveExemption().createDateTime)} and changes can no longer be made to this home unless it is restored. See Unit Notes for further information.` // eslint-disable-line max-len
-            : `This manufactured home has been exempt as of ${pacificDate(getActiveExemption().createDateTime)} and changes can no longer be made to this home unless it is restored.  If you require further information please contact BC Registries staff. ` // eslint-disable-line max-len
+          return `${pacificDate(getActiveExemption().createDateTime)}`
         }
+      }),
+      hasAlertMsg: false,
+      alertMsg: computed((): string => {
         // not all MHR Info will have the frozenDocumentType
         if (!getMhrInformation.value?.frozenDocumentType && !localState.hasAlertMsg) return
         // display alert message based o the locker document type

diff --git a/ppr-ui/tests/unit/MhrInformation.spec.ts b/ppr-ui/tests/unit/MhrInformation.spec.ts
@@ -1060,17 +1060,15 @@ describe('Mhr Information', () => {
     await nextTick()
 
     expect(wrapper.find(getTestId('correct-into-desc')).exists()).toBeFalsy()
-    expect(wrapper.find(getTestId('mhr-alert-msg')).exists()).toBeTruthy()
-    // message for Staff should contain unique text
-    expect(wrapper.find(getTestId('mhr-alert-msg')).text()).toContain('See Unit Notes for further information')
-    expect(wrapper.find(HomeOwners).find('#home-owners-change-btn').exists()).toBeFalsy()
+    //design updated, no more alert msg exists with residential exemption
+    expect(wrapper.find(getTestId('mhr-alert-msg')).exists()).toBeFalsy()
 
     // setup Qualified Supplier as Manufacturer
     await store.setAuthRoles([AuthRoles.MHR_TRANSFER_SALE])
     await store.setUserProductSubscriptionsCodes([ProductCode.MANUFACTURER])
     await nextTick()
 
     // message for QS should contain unique text
-    expect(wrapper.find(getTestId('mhr-alert-msg')).text()).toContain('contact BC Registries staff')
+    expect(wrapper.find(getTestId('mhr-alert-msg')).exists()).toBeFalsy()
   })
 })