Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add okx wallet to eco page #1574

Closed
wants to merge 5 commits into from
Closed

add okx wallet to eco page #1574

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
76e23b3
Update ecosystem.json
BanditBun Jan 17, 2025
91c1ba0
Add files via upload
BanditBun Jan 17, 2025
dfa5722
Update ecosystem.json
BanditBun Jan 19, 2025
6efe0a2
Update ecosystem.json
BanditBun Jan 19, 2025
28b0d86
Merge branch 'master' into master-okx
BanditBun Jan 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added apps/web/public/images/partners/okxwallet192.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 8 additions & 0 deletions apps/web/src/data/ecosystem.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,14 @@
"imageUrl": "/images/partners/arcadia-games.png",
"category": "consumer",
"subcategory": "gaming"
},
{
"name": "OKX Wallet",
"description": "OKX Wallet is an universal crypto wallet available on multiple platforms, including app, web, and extension.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change:

  • is a universal instead of is an universal
  • including app to including as an app

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wording changed, thx!

"url": "https://www.okx.com/web3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link points to a prices page, rather than an installation page for the wallet; please update

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to download page

"imageUrl": "/images/partners/okxwallet192.png",
"category": "wallet",
"subcategory": "self-custody"
},
{
"name": "Moxie Protocol",
Expand Down