add okx wallet to eco page #1574
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add OKX Wallet info
okx wallet icon
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🟡 Heimdall Review Status
|
|
@BanditBun is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
wbnns
reviewed
Jan 17, 2025
apps/web/src/data/ecosystem.json
Outdated
| }, | ||
| { | ||
| "name": "OKX Wallet", | ||
| "description": "OKX Wallet is an universal crypto wallet available on multiple platforms, including app, web, and extension.", |
There was a problem hiding this comment.
Please change:
is a universalinstead ofis an universalincluding apptoincluding as an app
wbnns
reviewed
Jan 17, 2025
apps/web/src/data/ecosystem.json
Outdated
| { | ||
| "name": "OKX Wallet", | ||
| "description": "OKX Wallet is an universal crypto wallet available on multiple platforms, including app, web, and extension.", | ||
| "url": "https://www.okx.com/web3", |
There was a problem hiding this comment.
This link points to a prices page, rather than an installation page for the wallet; please update
|
@BanditBun Hi there! Left a few comments in-line to resolve. Thanks for the PR! |
wbnns
added
change(s) requested
Update according to comments
changes to comment suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
add okx wallet to eco page
Notes to reviewers
okx wallet update
How has it been tested?
no need