CAN driver for Stm32g0 FDCAN #813
Open
+1,366
−772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes Register a strongly typed enum and updates all usages.
Starts prepping for a message buffer of a different size.
Refactors the TCAN's global insterrupt status clear code into a device-specific function.
- Fixes TX message buffer size. - Forks some registers that are different in the TCAN and STM32 FDCAN - Makes message buffer reads and writes be word oriented.
Rearranges the enums. Updates register_read/write for the 4550. Renames MCANCan to MCAN. Adds todos for some refactoring.
bakerstu
approved these changes
Jan 21, 2025
| RSVD11, ///< reserved | ||
| RSVD12, ///< reserved | ||
| RSVD13, ///< reserved | ||
| // From here on the register offsets differ between |
There was a problem hiding this comment.
This commentary about STM32 differences belongs in the STM32MCAN.hxx file.
| }; | ||
|
|
||
| template<unsigned DATA_BYTES> | ||
| struct MCANCommonDefs { |
| /// @param rx_timeout_bits timeout in CAN bit periods for rx interrupt | ||
| void init(const char *spi_name, uint32_t freq, uint32_t baud, | ||
| uint16_t rx_timeout_bits); | ||
| /// These registers exist in the Bosch MCAN but not with the same layout in the |
There was a problem hiding this comment.
This commentary belongs in the STM32MCAN file(s).
| * @file TCAN4550Can.hxx | ||
| * This file implements the CAN driver for the TCAN4550 CAN Controller. | ||
| * @file MCAN.hxx | ||
| * This file implements a generic CAN driver for the MCAN controller IP. |
There was a problem hiding this comment.
Maybe it is a good idea to summarize here what should eventually be moved out of this file related to TCAN4550 and/or STM32MCAN.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstracts the TCAN4550 driver into a generic Bosch MCAN driver and a specialization for the TCAN4550.
Adds new specialization for the STM32 FDCAN controller.