Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_planning_test_manager): remove dependency of VirtualTrafficLightState and ExpandStopRange #9953

Merged
merged 2 commits into from
Jan 19, 2025
+41 −34

modify obstacle_stop test code

64e5a46
Select commit
Loading
Failed to load commit list.
Merged

feat(autoware_planning_test_manager): remove dependency of VirtualTrafficLightState and ExpandStopRange #9953

modify obstacle_stop test code
64e5a46
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Jan 19, 2025 in 36s

CodeScene PR Check

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.02 (9.52 -> 9.55)

  • Improving Code Health: 2 findings(s) ✅

View detailed results in CodeScene

Details

✅ Improving Code Health:

  • Primitive Obsession autoware_planning_test_manager.cpp
  • String Heavy Function Arguments autoware_planning_test_manager.cpp

Annotations

Check notice on line 1 in planning/autoware_planning_test_manager/src/autoware_planning_test_manager.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ Getting better: Primitive Obsession 

The ratio of primitive types in function arguments decreases from 45.26% to 45.05%, threshold = 30.0%. The functions in this file have too many primitive types (e.g. int, double, float) in their function argument lists. Using many primitive types lead to the code smell Primitive Obsession. Avoid adding more primitive arguments.

Check notice on line 1 in planning/autoware_planning_test_manager/src/autoware_planning_test_manager.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ Getting better: String Heavy Function Arguments 

The ratio of strings in function arguments decreases from 43.16% to 42.86%, threshold = 39.0%. The functions in this file have a high ratio of strings as arguments. Avoid adding more.
View more details on CodeScene Delta Analysis