feat(autoware_planning_test_manager): remove dependency of VirtualTrafficLightState and ExpandStopRange #9953
+41
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
takayuki5168
added
the
run:build-and-test-differential
takayuki5168
changed the title
…affic light Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
takayuki5168
force-pushed
the
feat/organize-virtual-traffic-light-test
branch
from
0ab202a to
64e5a46
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9953 +/- ##
==========================================
- Coverage 29.16% 29.15% -0.01%
==========================================
Files 1424 1425 +1
Lines 107822 107825 +3
Branches 42237 42235 -2
==========================================
- Hits 31446 31441 -5
- Misses 73331 73339 +8
Partials 3045 3045
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
takayuki5168
requested review from
kosuke55,
soblin,
shmpwk,
tkimura4,
kyoichi-sugahara,
TakaHoribe,
satoshi-ota and
taikitanaka3
as code owners
kosuke55
approved these changes
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
VirtualTrafficLightState and ExpandStopRange are very specific message types for the planner package (behavior_velocity_virtual_traffic_light and obstacle_stop_planner respectively).
Currently, the autoware_planning_test_manager package, which is a common package, depends on these specific messages, which is unexpected.
This PR removed the dependency by moving the code from the autoware_planning_test_manager package to the specific planner package.
Related links
How was this PR tested?
unit test passed.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.