Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_perception_launch): add option for new TL detector model #9731

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
+218 −22

fix: new tlr for multi cameras

b5dbea3
Select commit
Loading
Failed to load commit list.
Open

feat(tier4_perception_launch): add option for new TL detector model #9731

fix: new tlr for multi cameras
b5dbea3
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Jan 29, 2025 in 1m 19s

CodeScene PR Check

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.12 (9.18 -> 9.06)

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method traffic_light_node_container.launch.py: create_traffic_light_node_container

Annotations

Check warning on line 285 in launch/tier4_perception_launch/launch/traffic_light_recognition/traffic_light_node_container.launch.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Large Method 

create_traffic_light_node_container increases from 136 to 217 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
View more details on CodeScene Delta Analysis