feat: add timeouts of request services #6532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TetsuKawa <[email protected]>
github-actions
bot
added
type:documentation
TetsuKawa
added
the
run:build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6532 +/- ##
==========================================
+ Coverage 14.77% 14.81% +0.03%
==========================================
Files 1917 1917
Lines 132319 132001 -318
Branches 39298 39236 -62
==========================================
- Hits 19552 19551 -1
+ Misses 90941 90637 -304
+ Partials 21826 21813 -13
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
veqcc
reviewed
Mar 4, 2024
veqcc
reviewed
Mar 4, 2024
veqcc
reviewed
Mar 4, 2024
Signed-off-by: TetsuKawa <[email protected]>
Signed-off-by: TetsuKawa <[email protected]>
Signed-off-by: TetsuKawa <[email protected]>
|
@TetsuKawa Build is failing. It seems that the function name is different. |
HansRobo
pushed a commit
that referenced
this pull request
Mar 12, 2024
* feat: add timeouts of request services Signed-off-by: TetsuKawa <[email protected]> * style(pre-commit): autofix * feat: replace define with enum Signed-off-by: TetsuKawa <[email protected]> * style(pre-commit): autofix * modify: renam a function Signed-off-by: TetsuKawa <[email protected]> * modify: rename a function Signed-off-by: TetsuKawa <[email protected]> * modify: fix functions name at the caller side Signed-off-by: TetsuKawa <[email protected]> --------- Signed-off-by: TetsuKawa <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Takagi, Isamu <[email protected]> Co-authored-by: Ryuta Kambe <[email protected]> Signed-off-by: Kotaro Yoshimoto <[email protected]>
kaigohirao
pushed a commit
to kaigohirao/autoware.universe
that referenced
this pull request
Mar 22, 2024
* feat: add timeouts of request services Signed-off-by: TetsuKawa <[email protected]> * style(pre-commit): autofix * feat: replace define with enum Signed-off-by: TetsuKawa <[email protected]> * style(pre-commit): autofix * modify: renam a function Signed-off-by: TetsuKawa <[email protected]> * modify: rename a function Signed-off-by: TetsuKawa <[email protected]> * modify: fix functions name at the caller side Signed-off-by: TetsuKawa <[email protected]> --------- Signed-off-by: TetsuKawa <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Takagi, Isamu <[email protected]> Co-authored-by: Ryuta Kambe <[email protected]> Signed-off-by: kaigohirao <[email protected]>
mkuri
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Mar 28, 2024
* feat: add timeouts of request services Signed-off-by: TetsuKawa <[email protected]> * style(pre-commit): autofix * feat: replace define with enum Signed-off-by: TetsuKawa <[email protected]> * style(pre-commit): autofix * modify: renam a function Signed-off-by: TetsuKawa <[email protected]> * modify: rename a function Signed-off-by: TetsuKawa <[email protected]> * modify: fix functions name at the caller side Signed-off-by: TetsuKawa <[email protected]> --------- Signed-off-by: TetsuKawa <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Takagi, Isamu <[email protected]> Co-authored-by: Ryuta Kambe <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
* feat: add timeouts of request services Signed-off-by: TetsuKawa <[email protected]> * style(pre-commit): autofix * feat: replace define with enum Signed-off-by: TetsuKawa <[email protected]> * style(pre-commit): autofix * modify: renam a function Signed-off-by: TetsuKawa <[email protected]> * modify: rename a function Signed-off-by: TetsuKawa <[email protected]> * modify: fix functions name at the caller side Signed-off-by: TetsuKawa <[email protected]> --------- Signed-off-by: TetsuKawa <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Takagi, Isamu <[email protected]> Co-authored-by: Ryuta Kambe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds timeout processing when requesting service to mrm operator.
Related links
Tests performed
Confirmed that the timeout process works.
Confirmed that the emergency_stop request is called after a mrm request failed (timed out).
Confirmed that the emergency_stop request also failed and mrm state transition to MRM_FAILED.
Notes for reviewers
Please come up with a better default value for timeout.
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.