Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(multi_object_tracker): add missing diagnostic_updater dependency #6025

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Jan 8, 2024

Description

multi_object_tracker is missing a dependency for diagnostic_updater

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jan 8, 2024
@esteve esteve added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 8, 2024
@esteve esteve enabled auto-merge (squash) January 8, 2024 12:07
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f4ea429) 15.22% compared to head (bd45555) 15.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6025   +/-   ##
=======================================
  Coverage   15.22%   15.22%           
=======================================
  Files        1751     1751           
  Lines      120898   120898           
  Branches    36778    36778           
=======================================
  Hits        18407    18407           
  Misses      81813    81813           
  Partials    20678    20678           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 15.22% <ø> (ø) Carriedforward from f4ea429

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@esteve esteve merged commit dddde07 into main Jan 8, 2024
38 checks passed
@esteve esteve deleted the multi-object-tracker-fix-dep branch January 8, 2024 18:52
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants