Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_velocity_planner): output path's interval can be designated by yaml #6023

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jan 7, 2024

Description

Currently, the output path's interval of the behavior_velocity_planner is decided in the default argument of the utility function, which is hard to find and cannot be changed easily.

This PR moves the interval variable to the yaml file.

Tests performed

psim

Effects on system behavior

Nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 7, 2024
@takayuki5168 takayuki5168 marked this pull request as ready for review January 7, 2024 06:22
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 7, 2024
Copy link

codecov bot commented Jan 7, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (5de111f) 15.23% compared to head (6ee8cf8) 15.23%.
Report is 2 commits behind head on main.

Files Patch % Lines
planning/behavior_velocity_planner/src/node.cpp 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6023      +/-   ##
==========================================
- Coverage   15.23%   15.23%   -0.01%     
==========================================
  Files        1751     1751              
  Lines      120918   120919       +1     
  Branches    36770    36771       +1     
==========================================
  Hits        18423    18423              
  Misses      81824    81824              
- Partials    20671    20672       +1     
Flag Coverage Δ *Carryforward flag
differential 12.20% <0.00%> (?)
total 15.23% <ø> (+<0.01%) ⬆️ Carriedforward from 5de111f

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 merged commit fdeb24c into autowarefoundation:main Jan 9, 2024
36 of 40 checks passed
@takayuki5168 takayuki5168 deleted the refactor/behavior-vel-interval-yaml branch January 9, 2024 04:11
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants