Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(dynamic_avoidance): separate dynamic avoidance module #6019

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jan 6, 2024

Description

Refactored the dynamic avoidance scene module from the behavior_path_planner package to a separate package behavior_path_dynamic_avoidance_module. This improves the modularity, reusability, and configurability of the scene modules for planning. Renamed and moved the source files, header files, parameter files, and plugin descriptions accordingly. Added unit tests for the dynamic avoidance module using the planning_interface_test_manager package.

Tests performed

psim

Effects on system behavior

Nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Jan 6, 2024
@takayuki5168 takayuki5168 force-pushed the refactor/dynamic-avoidance-separete-package branch from d366f90 to 77d7645 Compare January 6, 2024 16:02
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 6, 2024
@takayuki5168 takayuki5168 marked this pull request as ready for review January 6, 2024 16:02
Signed-off-by: Takayuki Murooka <[email protected]>
@takayuki5168 takayuki5168 added the run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Jan 6, 2024
@takayuki5168
Copy link
Contributor Author

@satoshi-ota Could you review the PR? Just a quick look is enough.

Copy link

codecov bot commented Jan 6, 2024

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (5de111f) 15.23% compared to head (d5fe8e7) 15.17%.

Files Patch % Lines
...test/test_behavior_path_planner_node_interface.cpp 26.66% 0 Missing and 33 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6019      +/-   ##
==========================================
- Coverage   15.23%   15.17%   -0.07%     
==========================================
  Files        1751     1756       +5     
  Lines      120918   121860     +942     
  Branches    36770    37338     +568     
==========================================
+ Hits        18421    18487      +66     
- Misses      81825    82461     +636     
- Partials    20672    20912     +240     
Flag Coverage Δ *Carryforward flag
differential 9.42% <26.66%> (?)
total 15.23% <ø> (+<0.01%) ⬆️ Carriedforward from f975b11

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Takayuki Murooka <[email protected]>
Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takayuki5168 takayuki5168 merged commit a96c71c into autowarefoundation:main Jan 9, 2024
22 of 25 checks passed
@takayuki5168 takayuki5168 deleted the refactor/dynamic-avoidance-separete-package branch January 9, 2024 02:10
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
…arefoundation#6019)

* refactor(dynamic_avoidance): separate dynamic avoidance module

Signed-off-by: Takayuki Murooka <[email protected]>

* move figures

Signed-off-by: Takayuki Murooka <[email protected]>

* update .pages

Signed-off-by: Takayuki Murooka <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…arefoundation#6019)

* refactor(dynamic_avoidance): separate dynamic avoidance module

Signed-off-by: Takayuki Murooka <[email protected]>

* move figures

Signed-off-by: Takayuki Murooka <[email protected]>

* update .pages

Signed-off-by: Takayuki Murooka <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…arefoundation#6019)

* refactor(dynamic_avoidance): separate dynamic avoidance module

Signed-off-by: Takayuki Murooka <[email protected]>

* move figures

Signed-off-by: Takayuki Murooka <[email protected]>

* update .pages

Signed-off-by: Takayuki Murooka <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…arefoundation#6019)

* refactor(dynamic_avoidance): separate dynamic avoidance module

Signed-off-by: Takayuki Murooka <[email protected]>

* move figures

Signed-off-by: Takayuki Murooka <[email protected]>

* update .pages

Signed-off-by: Takayuki Murooka <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants