feat(path_smoother): add a plotter of calculation time #6012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takayuki Murooka <[email protected]>
github-actions
bot
added
the
component:planning
Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
takayuki5168
requested review from
maxime-clem,
kosuke55 and
TakaHoribe
as code owners
takayuki5168
added
the
run:build-and-test-differential
Signed-off-by: Takayuki Murooka <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6012 +/- ##
=======================================
Coverage 15.22% 15.22%
=======================================
Files 1751 1751
Lines 120849 120849
Branches 36721 36721
=======================================
Hits 18398 18398
Misses 81810 81810
Partials 20641 20641
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
maxime-clem
approved these changes
Jan 5, 2024
Comment on lines
+73
to
+74
| if len(self.y_vec[f_idx]) > self.depth: | ||
| self.y_vec[f_idx].popleft() |
There was a problem hiding this comment.
(minor) I think this can be implicitly achieved by initializing the deque with maxlen=self.depth (see https://docs.python.org/3/library/collections.html#collections.deque).
There was a problem hiding this comment.
Thank you. I will fix it with another PR.
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 26, 2024
…ation#6012) * feat(path_smoother): add a plotter of calculation time Signed-off-by: Takayuki Murooka <[email protected]> * add x/y label Signed-off-by: Takayuki Murooka <[email protected]> * fix Signed-off-by: Takayuki Murooka <[email protected]> * update cmake to install script Signed-off-by: Takayuki Murooka <[email protected]> --------- Signed-off-by: Takayuki Murooka <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…ation#6012) * feat(path_smoother): add a plotter of calculation time Signed-off-by: Takayuki Murooka <[email protected]> * add x/y label Signed-off-by: Takayuki Murooka <[email protected]> * fix Signed-off-by: Takayuki Murooka <[email protected]> * update cmake to install script Signed-off-by: Takayuki Murooka <[email protected]> --------- Signed-off-by: Takayuki Murooka <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…ation#6012) * feat(path_smoother): add a plotter of calculation time Signed-off-by: Takayuki Murooka <[email protected]> * add x/y label Signed-off-by: Takayuki Murooka <[email protected]> * fix Signed-off-by: Takayuki Murooka <[email protected]> * update cmake to install script Signed-off-by: Takayuki Murooka <[email protected]> --------- Signed-off-by: Takayuki Murooka <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…ation#6012) * feat(path_smoother): add a plotter of calculation time Signed-off-by: Takayuki Murooka <[email protected]> * add x/y label Signed-off-by: Takayuki Murooka <[email protected]> * fix Signed-off-by: Takayuki Murooka <[email protected]> * update cmake to install script Signed-off-by: Takayuki Murooka <[email protected]> --------- Signed-off-by: Takayuki Murooka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a plotter of the calculation time of the path_smoother package.
Tests performed
psim
Effects on system behavior
nothing
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.