docs(start_planner): update Purpose / Role of the document #6002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kyoichi-sugahara <[email protected]>
kyoichi-sugahara
requested review from
kosuke55,
satoshi-ota,
shmpwk,
TomohitoAndo and
tkimura4
as code owners
github-actions
bot
added
type:documentation
kosuke55
reviewed
Jan 1, 2024
| @@ -2,17 +2,23 @@ | |||
|
|
|||
| ## Purpose / Role | |||
|
|
|||
| The Start Planner module is designed to generate a path from the current ego position to the driving lane, avoiding static obstacles and implementing safety checks against dynamic obstacles. (Note: The feature of safety checks against dynamic obstacles is currently a work in progress.) | |||
| This module is activated when a new route is received. | |||
There was a problem hiding this comment.
changed expression in this PR from
The Start Planner module is designed to generate a path from the current ego position to the driving lane, avoiding static obstacles and implementing safety checks against dynamic obstacles. (Note: The feature of safety checks against dynamic obstacles is currently a work in progress.)
to
The Start Planner module is designed to generate a path from the current ego position to the driving lane, avoiding static obstacles and stopping in response to dynamic obstacles when a collision is detected.
And for the following description is not correct in my understanding 🤔
This module is activated when a new route is received.
activated condition is not only receiving new route?
There was a problem hiding this comment.
I thought the tivated condition is only receiving new route. What are other conditions?
(I can not check the code details now🙇)
There was a problem hiding this comment.
memo:
ex) even if reciving new route, the ego deviates from center line the module is not executed.
There was a problem hiding this comment.
will update to add acivation condition section
kyoichi-sugahara
changed the title
kyoichi-sugahara
changed the title
kosuke55
approved these changes
Jan 10, 2024
kyoichi-sugahara
added
the
run:build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6002 +/- ##
=======================================
Coverage 15.22% 15.22%
=======================================
Files 1751 1751
Lines 120849 120849
Branches 36721 36721
=======================================
Hits 18398 18398
Misses 81810 81810
Partials 20641 20641
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kyoichi-sugahara
merged commit 142bc49
into
autowarefoundation:main
44 of 47 checks passed
kyoichi-sugahara
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jan 11, 2024
…oundation#6002) Update Start Planner module to stop in response to dynamic obstacles Signed-off-by: kyoichi-sugahara <[email protected]>
This was referenced Jan 11, 2024
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 26, 2024
…oundation#6002) Update Start Planner module to stop in response to dynamic obstacles Signed-off-by: kyoichi-sugahara <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…oundation#6002) Update Start Planner module to stop in response to dynamic obstacles Signed-off-by: kyoichi-sugahara <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…oundation#6002) Update Start Planner module to stop in response to dynamic obstacles Signed-off-by: kyoichi-sugahara <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…oundation#6002) Update Start Planner module to stop in response to dynamic obstacles Signed-off-by: kyoichi-sugahara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update Purpose / Role of the document
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.