Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dynamic_avoidance): apply ego's lateral acc/jerk constraints to object polygon #5953

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Dec 25, 2023

Description

In order to suppress sudden steering by the change of the drivable area just in front of the ego, the feasible ego's path considering lateral acc/jerk is calculated, and the object polygon to be removed from the drivable area is limited to this feasible path.

Tests performed

psim

Effects on system behavior

Nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 25, 2023
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 25, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review December 25, 2023 11:27
Copy link

codecov bot commented Dec 25, 2023

Codecov Report

Attention: 95 lines in your changes are missing coverage. Please review.

Comparison is base (ed8ffea) 15.22% compared to head (8f75b0f) 15.22%.
Report is 1 commits behind head on main.

Files Patch % Lines
...ule/dynamic_avoidance/dynamic_avoidance_module.cpp 11.26% 49 Missing and 14 partials ⚠️
...ule/dynamic_avoidance/dynamic_avoidance_module.hpp 20.00% 15 Missing and 5 partials ⚠️
...ner/src/scene_module/dynamic_avoidance/manager.cpp 0.00% 0 Missing and 6 partials ⚠️
...ior_path_planner_common/src/marker_utils/utils.cpp 25.00% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5953   +/-   ##
=======================================
  Coverage   15.22%   15.22%           
=======================================
  Files        1751     1751           
  Lines      120849   120933   +84     
  Branches    36721    36768   +47     
=======================================
+ Hits        18398    18413   +15     
- Misses      81810    81853   +43     
- Partials    20641    20667   +26     
Flag Coverage Δ *Carryforward flag
differential 11.68% <13.63%> (?)
total 15.22% <ø> (+<0.01%) ⬆️ Carriedforward from ed8ffea

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
@takayuki5168 takayuki5168 force-pushed the feat/dynamic-avoidance-suppress-sudden-steering branch from 0aee8f3 to 8f75b0f Compare January 4, 2024 13:25
@takayuki5168 takayuki5168 merged commit 5de111f into autowarefoundation:main Jan 5, 2024
21 of 24 checks passed
@takayuki5168 takayuki5168 deleted the feat/dynamic-avoidance-suppress-sudden-steering branch January 5, 2024 07:38
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
…object polygon (autowarefoundation#5953)

* feat(dynamic_avoidance): apply ego's lateral acc/jerk constraints to object polygon

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…object polygon (autowarefoundation#5953)

* feat(dynamic_avoidance): apply ego's lateral acc/jerk constraints to object polygon

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…object polygon (autowarefoundation#5953)

* feat(dynamic_avoidance): apply ego's lateral acc/jerk constraints to object polygon

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…object polygon (autowarefoundation#5953)

* feat(dynamic_avoidance): apply ego's lateral acc/jerk constraints to object polygon

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>
satoshi-ota pushed a commit to tier4/autoware.universe that referenced this pull request Jun 6, 2024
…object polygon (autowarefoundation#5953)

* feat(dynamic_avoidance): apply ego's lateral acc/jerk constraints to object polygon

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants