[red-knot] handle synthetic 'self' argument in call-binding diagnostics #15362
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In binding calls, we store an argument index with argument-specific binding errors, so that we can emit the diagnostic on the specific argument node at the call site.
We need to account for the synthetic
self
argument for methods, or else our argument index is off by one and can result in a panic where we are looking for an argument node that doesn't exist in the call.Fixes #15360
Test Plan
Added mdtest.
Also verified that with this fix, red-knot can again run on Black codebase without panic.