feat(x/mint): remove inflation_rewards_ratio param
#305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdymylja
reviewed
Mar 6, 2023
fdymylja
reviewed
Mar 6, 2023
fdymylja
reviewed
Mar 6, 2023
| // Track inflation rewards | ||
| k.rewardsKeeper.TrackInflationRewards(ctx, dappRewards[0]) | ||
| // Update the minimum consensus fee | ||
| k.rewardsKeeper.UpdateMinConsensusFee(ctx, dappRewards[0]) |
There was a problem hiding this comment.
Now the MinConsensusFee is not tracked. We need to find a way to track it again.
There was a problem hiding this comment.
Yup. Mentioned this in the BeginBlocker issue. #287 (comment) so that when actual minting is implemented, it is handled.
fdymylja
reviewed
Mar 6, 2023
| } | ||
|
|
||
| // Track inflation rewards | ||
| k.rewardsKeeper.TrackInflationRewards(ctx, dappRewards[0]) |
There was a problem hiding this comment.
We need to track the inflation rewards too
There was a problem hiding this comment.
Implantation tracked in #287 (comment) issue
fdymylja
reviewed
Mar 6, 2023
fdymylja
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inflation_rewards_ratioparam from x/rewards as now x/mint params.inflationrecipients will store this info