Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(x/mint): app wiring #304

Merged
merged 8 commits into from
Mar 7, 2023
Merged

feat(x/mint): app wiring #304

merged 8 commits into from
Mar 7, 2023

Conversation

spoo-bar
Copy link
Contributor

@spoo-bar spoo-bar commented Mar 2, 2023 •
edited
Loading

Closes: #289

  • Replaces sdk/mint module references with our custom x/mint
  • Updating existing func calls to the new x/mint module
  • Updating InitGenesis logic to individually check for LastBlockInfo missing
  • Adding InitGenesis & ExportGenesis tests

❗Some tests are still failing cuz minting has not been implemented yet

@spoo-bar spoo-bar requested a review from fdymylja March 2, 2023 17:09
@spoo-bar spoo-bar marked this pull request as ready for review March 2, 2023 17:09
fdymylja
fdymylja reviewed Mar 3, 2023
View reviewed changes
Copy link
Contributor

@fdymylja fdymylja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be removing x/rewards/mintbankkeeper, as it was doing inflation splitting between the rewards module and the staking module.

@spoo-bar spoo-bar requested a review from fdymylja March 3, 2023 15:04
@spoo-bar
Copy link
Contributor Author

spoo-bar commented Mar 6, 2023 •
edited
Loading

We should be removing x/rewards/mintbankkeeper, as it was doing inflation splitting between the rewards module and the staking module.

Handled in separate PR #305

@spoo-bar spoo-bar merged commit dbcdd1a into feat/econ-v2 Mar 7, 2023
@spoo-bar spoo-bar deleted the spoorthi/wire-new-mint branch March 7, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdymylja fdymylja fdymylja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spoo-bar @fdymylja