-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumps #431
Bumps #431
Conversation
go version to 1.22.0 go toolchain to 1.22.3
For static build, get pc info from the freshly built libbpf.a instead of the system one. For dynamic build, set only the required ldflags for the system libbpf.
f89f342
to
85bc882
Compare
@rscampos it would be nice to test it on arm64. |
32eec76
to
143d1c2
Compare
@rscampos as you mentioned in geyslan#8 (comment), next step is to decide what style .clang-format will enforce to us. 👍🏼 |
clang-format pinned to the same version of the clang compiler. Co-authored-by: Raphael Campos <[email protected]>
@geyslan I did some tests on arm... just need to change to clang-format-14, all good :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -1,6 +1,8 @@ | |||
module github.com/aquasecurity/libbpfgo | |||
|
|||
go 1.21 | |||
go 1.22.0 |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are not supposed to dictate what go version is necessary for the consumers unless it's actually necessary:
No matter how good the latest Go version is, if it's not a requirement, you are not supposed to force it. You set the minimum supported Go version instead. Go supports two major releases at any time and it seems reasonable to do at least the same thing.
People with patched go versions might not have an ability to upgrade to the latest release.
I don't think there's a good reason to set toolchain
for a library ever.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're absolutely right. I'm going to revert (soon) this PR by splitting the fix and other chores into their own PRs. 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I appreciate it.
commit 517e2d5
commit 46560d5
commit 7b0db19
commit 098f20b
commit 76bd3af