Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Bumps" #433

Merged
merged 5 commits into from
May 28, 2024
Merged

Revert "Bumps" #433

merged 5 commits into from
May 28, 2024

Conversation

geyslan
Copy link
Member

@geyslan geyslan commented May 28, 2024

Reverts #431

As well reminded by @bobrik, even if we can, we shouldn't force consumers to use specific go versions by declaring toolchain or raising the minimum version.

As a good practice, whenever possible, we should keep libbpfgo aligned with the last two go major releases.

This reverted PR will be reworked in upcoming ones.

@geyslan geyslan requested a review from rscampos May 28, 2024 12:49
@geyslan geyslan self-assigned this May 28, 2024
Copy link
Collaborator

@rscampos rscampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geyslan geyslan merged commit 450de10 into main May 28, 2024
17 checks passed
@geyslan geyslan deleted the revert-431-bumps branch January 9, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants