Remove unused implementation dependencies or move them to runtime
#3168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Dependency-analysis plugin detected that some `implementation` dependencies are unused can can be either removed or downgraded to `runtimeOnly` / `testImplementation` scopes. Modifications: - Remove unused `implementation` dependencies. - Downgrade required to `runtimeOnly` / `testImplementation` scopes. - Regenerate lock files. Result: Addresses warning from dependency-analysis plugin that recommend cleaning up `implementation` dependencies. Risk for users: Should be none, as `implementation` dependencies they were `runtime` for our users. So, they could not depend on that code directly without explicitly declaring them in their build file.
bryce-anderson
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Dependency-analysis plugin detected that some
implementationdependencies are unused and can be either removed or downgraded toruntimeOnly/testImplementationscopes.Modifications:
implementationdependencies.runtimeOnly/testImplementationscopes.Result:
Addresses warning from dependency-analysis plugin that recommends cleaning up
implementationdependencies.Risk for users:
Should be none, as
implementationdependencies they wereruntimefor our users. So, they could not depend on that code directly without explicitly declaring them in their build file.