Remove unused implementation dependencies or move them to runtime (…

…#3168)

Motivation:

Dependency-analysis plugin detected that some `implementation` dependencies are unused and can be either removed or downgraded to `runtimeOnly` / `testImplementation` scopes.

Modifications:

- Remove unused `implementation` dependencies.
- Downgrade required to `runtimeOnly` / `testImplementation` scopes.
- Regenerate lock files.

Result:

Addresses warning from dependency-analysis plugin that recommends cleaning up `implementation` dependencies.

Risk for users:

Should be none, as `implementation` dependencies they were `runtime` for our users. So, they could not depend on that code directly without explicitly declaring them in their build file.

servicetalk-buffer-netty/build.gradle

@@ -24,7 +24,6 @@ dependencies {
   implementation project(":servicetalk-annotations")
   implementation project(":servicetalk-utils-internal")
   implementation "io.netty:netty-common"
-  implementation "org.slf4j:slf4j-api:$slf4jVersion"
 
   testImplementation enforcedPlatform("org.junit:junit-bom:$junit5Version")
   testImplementation project(":servicetalk-test-resources")

servicetalk-concurrent-api-test/build.gradle

@@ -22,7 +22,6 @@ dependencies {
 
   implementation project(":servicetalk-annotations")
   implementation project(":servicetalk-concurrent-internal")
-  implementation project(":servicetalk-concurrent-test-internal")
   implementation project(":servicetalk-utils-internal")
 
   testImplementation enforcedPlatform("org.junit:junit-bom:$junit5Version")

servicetalk-concurrent-jdkflow/build.gradle

@@ -41,7 +41,6 @@ dependencies {
     api project(":servicetalk-concurrent-api")
 
     implementation project(":servicetalk-annotations")
-    implementation "org.slf4j:slf4j-api:$slf4jVersion"
 
     testImplementation enforcedPlatform("org.junit:junit-bom:$junit5Version")
     testImplementation testFixtures(project(":servicetalk-concurrent-api"))

servicetalk-concurrent-jdkflow/gradle.lockfile

@@ -3,5 +3,5 @@
 # This file is expected to be part of source control.
 com.google.code.findbugs:jsr305:3.0.2=compileClasspath,runtimeClasspath
 org.jctools:jctools-core:4.0.3=runtimeClasspath
-org.slf4j:slf4j-api:1.7.36=compileClasspath,runtimeClasspath
+org.slf4j:slf4j-api:1.7.36=runtimeClasspath
 empty=annotationProcessor,jmhCompileClasspath,jmhRuntimeClasspath,spotbugsPlugins,testAnnotationProcessor

servicetalk-concurrent-reactivestreams/build.gradle

@@ -35,15 +35,14 @@ dependencies {
   api "org.reactivestreams:reactive-streams:$reactiveStreamsVersion"
 
   implementation project(":servicetalk-annotations")
-  implementation project(":servicetalk-serializer-utils")
-  implementation project(":servicetalk-buffer-netty")
-  implementation "org.slf4j:slf4j-api:$slf4jVersion"
 
   testImplementation enforcedPlatform("org.junit:junit-bom:$junit5Version")
   testImplementation testFixtures(project(":servicetalk-concurrent-api"))
   testImplementation testFixtures(project(":servicetalk-concurrent-internal"))
   testImplementation project(":servicetalk-buffer-api")
+  testImplementation project(":servicetalk-buffer-netty")
   testImplementation project(":servicetalk-serializer-api")
+  testImplementation project(":servicetalk-serializer-utils")
   testImplementation project(":servicetalk-test-resources")
   testImplementation "org.junit.jupiter:junit-jupiter-api"
   testImplementation "org.mockito:mockito-core:$mockitoCoreVersion"

servicetalk-concurrent-reactivestreams/gradle.lockfile

@@ -2,10 +2,7 @@
 # Manual edits can break the build and are not advised.
 # This file is expected to be part of source control.
 com.google.code.findbugs:jsr305:3.0.2=compileClasspath,runtimeClasspath
-io.netty:netty-bom:4.1.116.Final=compileClasspath,runtimeClasspath
-io.netty:netty-buffer:4.1.116.Final=compileClasspath,runtimeClasspath
-io.netty:netty-common:4.1.116.Final=compileClasspath,runtimeClasspath
 org.jctools:jctools-core:4.0.3=runtimeClasspath
 org.reactivestreams:reactive-streams:1.0.4=compileClasspath,runtimeClasspath
-org.slf4j:slf4j-api:1.7.36=compileClasspath,runtimeClasspath
+org.slf4j:slf4j-api:1.7.36=runtimeClasspath
 empty=annotationProcessor,jmhCompileClasspath,jmhRuntimeClasspath,spotbugsPlugins,testAnnotationProcessor,testFixturesAnnotationProcessor

servicetalk-data-jackson-jersey/build.gradle

@@ -33,26 +33,24 @@ dependencies {
 
   implementation project(":servicetalk-annotations")
   implementation project(":servicetalk-buffer-api")
-  implementation project(":servicetalk-buffer-netty")
   implementation project(":servicetalk-concurrent-api")
-  implementation project(":servicetalk-concurrent-api-internal")
   implementation project(":servicetalk-concurrent-internal")
-  implementation project(":servicetalk-http-api")
-  implementation project(":servicetalk-http-router-jersey")
   implementation project(":servicetalk-http-router-jersey-internal")
-  implementation project(":servicetalk-http-utils")
   implementation project(":servicetalk-serialization-api")
   implementation project(":servicetalk-serializer-api")
   implementation project(":servicetalk-transport-api")
-  implementation project(":servicetalk-transport-netty")
   implementation "com.fasterxml.jackson.core:jackson-core"
   implementation "org.glassfish.hk2.external:jakarta.inject:$actualJavaxInjectVersion"
   implementation "org.glassfish.jersey.core:jersey-server"
   implementation "org.slf4j:slf4j-api:$slf4jVersion"
 
+  runtimeOnly project(":servicetalk-http-router-jersey")
+
   testImplementation enforcedPlatform("org.junit:junit-bom:$junit5Version")
   testImplementation testFixtures(project(":servicetalk-concurrent-internal"))
   testImplementation testFixtures(project(":servicetalk-http-router-jersey"))
+  testImplementation project(":servicetalk-buffer-netty")
+  testImplementation project(":servicetalk-http-api")
   testImplementation project(":servicetalk-test-resources")
   testImplementation "org.junit.jupiter:junit-jupiter-api"
   testImplementation "org.junit.jupiter:junit-jupiter-params"

servicetalk-data-jackson-jersey/gradle.lockfile

@@ -9,22 +9,6 @@ com.google.code.findbugs:jsr305:3.0.2=compileClasspath,runtimeClasspath
 com.sun.activation:jakarta.activation:1.2.2=runtimeClasspath
 com.sun.xml.bind:jaxb-core:2.3.0.1=runtimeClasspath
 com.sun.xml.bind:jaxb-impl:2.3.3=runtimeClasspath
-io.netty.incubator:netty-incubator-transport-classes-io_uring:0.0.26.Final=runtimeClasspath
-io.netty.incubator:netty-incubator-transport-native-io_uring:0.0.26.Final=runtimeClasspath
-io.netty:netty-bom:4.1.116.Final=compileClasspath,runtimeClasspath
-io.netty:netty-buffer:4.1.116.Final=compileClasspath,runtimeClasspath
-io.netty:netty-codec:4.1.116.Final=runtimeClasspath
-io.netty:netty-common:4.1.116.Final=compileClasspath,runtimeClasspath
-io.netty:netty-handler:4.1.116.Final=runtimeClasspath
-io.netty:netty-resolver:4.1.116.Final=runtimeClasspath
-io.netty:netty-tcnative-boringssl-static:2.0.69.Final=runtimeClasspath
-io.netty:netty-tcnative-classes:2.0.69.Final=runtimeClasspath
-io.netty:netty-transport-classes-epoll:4.1.116.Final=runtimeClasspath
-io.netty:netty-transport-classes-kqueue:4.1.116.Final=runtimeClasspath
-io.netty:netty-transport-native-epoll:4.1.116.Final=runtimeClasspath
-io.netty:netty-transport-native-kqueue:4.1.116.Final=runtimeClasspath
-io.netty:netty-transport-native-unix-common:4.1.116.Final=runtimeClasspath
-io.netty:netty-transport:4.1.116.Final=runtimeClasspath
 jakarta.activation:jakarta.activation-api:1.2.2=runtimeClasspath
 jakarta.annotation:jakarta.annotation-api:1.3.5=compileClasspath,runtimeClasspath
 jakarta.validation:jakarta.validation-api:2.0.2=compileClasspath,runtimeClasspath

servicetalk-data-jackson-jersey3-jakarta10/build.gradle

@@ -93,26 +93,24 @@ dependencies {
 
   implementation project(":servicetalk-annotations")
   implementation project(":servicetalk-buffer-api")
-  implementation project(":servicetalk-buffer-netty")
   implementation project(":servicetalk-concurrent-api")
-  implementation project(":servicetalk-concurrent-api-internal")
   implementation project(":servicetalk-concurrent-internal")
-  implementation project(":servicetalk-http-api")
-  implementation project(":servicetalk-http-router-jersey3-jakarta10")
   implementation project(":servicetalk-http-router-jersey3-jakarta10-internal")
-  implementation project(":servicetalk-http-utils")
   implementation project(":servicetalk-serialization-api")
   implementation project(":servicetalk-serializer-api")
   implementation project(":servicetalk-transport-api")
-  implementation project(":servicetalk-transport-netty")
   implementation "com.fasterxml.jackson.core:jackson-core"
   implementation "jakarta.inject:jakarta.inject-api:$actualJavaxInjectVersion"
   implementation "org.glassfish.jersey.core:jersey-server"
   implementation "org.slf4j:slf4j-api:$slf4jVersion"
 
+  runtimeOnly project(":servicetalk-http-router-jersey3-jakarta10")
+
   testImplementation enforcedPlatform("org.junit:junit-bom:$junit5Version")
   testImplementation testFixtures(project(":servicetalk-concurrent-internal"))
   testImplementation testFixtures(project(":servicetalk-http-router-jersey3-jakarta10"))
+  testImplementation project(":servicetalk-buffer-netty")
+  testImplementation project(":servicetalk-http-api")
   testImplementation project(":servicetalk-test-resources")
   testImplementation "org.junit.jupiter:junit-jupiter-api"
   testImplementation "org.junit.jupiter:junit-jupiter-params"

servicetalk-data-jackson-jersey3-jakarta10/gradle.lockfile

@@ -7,22 +7,6 @@ com.fasterxml.jackson.core:jackson-databind:2.16.2=compileClasspath,runtimeClass
 com.fasterxml.jackson:jackson-bom:2.16.2=compileClasspath,runtimeClasspath
 com.google.code.findbugs:jsr305:3.0.2=compileClasspath,runtimeClasspath
 com.sun.istack:istack-commons-runtime:4.1.2=runtimeClasspath
-io.netty.incubator:netty-incubator-transport-classes-io_uring:0.0.26.Final=runtimeClasspath
-io.netty.incubator:netty-incubator-transport-native-io_uring:0.0.26.Final=runtimeClasspath
-io.netty:netty-bom:4.1.116.Final=compileClasspath,runtimeClasspath
-io.netty:netty-buffer:4.1.116.Final=compileClasspath,runtimeClasspath
-io.netty:netty-codec:4.1.116.Final=runtimeClasspath
-io.netty:netty-common:4.1.116.Final=compileClasspath,runtimeClasspath
-io.netty:netty-handler:4.1.116.Final=runtimeClasspath
-io.netty:netty-resolver:4.1.116.Final=runtimeClasspath
-io.netty:netty-tcnative-boringssl-static:2.0.69.Final=runtimeClasspath
-io.netty:netty-tcnative-classes:2.0.69.Final=runtimeClasspath
-io.netty:netty-transport-classes-epoll:4.1.116.Final=runtimeClasspath
-io.netty:netty-transport-classes-kqueue:4.1.116.Final=runtimeClasspath
-io.netty:netty-transport-native-epoll:4.1.116.Final=runtimeClasspath
-io.netty:netty-transport-native-kqueue:4.1.116.Final=runtimeClasspath
-io.netty:netty-transport-native-unix-common:4.1.116.Final=runtimeClasspath
-io.netty:netty-transport:4.1.116.Final=runtimeClasspath
 jakarta.activation:jakarta.activation-api:2.1.3=runtimeClasspath
 jakarta.annotation:jakarta.annotation-api:2.1.1=compileClasspath,runtimeClasspath
 jakarta.inject:jakarta.inject-api:2.0.1=compileClasspath,runtimeClasspath

servicetalk-data-jackson-jersey3-jakarta9/build.gradle

@@ -93,26 +93,24 @@ dependencies {
 
   implementation project(":servicetalk-annotations")
   implementation project(":servicetalk-buffer-api")
-  implementation project(":servicetalk-buffer-netty")
   implementation project(":servicetalk-concurrent-api")
-  implementation project(":servicetalk-concurrent-api-internal")
   implementation project(":servicetalk-concurrent-internal")
-  implementation project(":servicetalk-http-api")
-  implementation project(":servicetalk-http-router-jersey3-jakarta9")
   implementation project(":servicetalk-http-router-jersey3-jakarta9-internal")
-  implementation project(":servicetalk-http-utils")
   implementation project(":servicetalk-serialization-api")
   implementation project(":servicetalk-serializer-api")
   implementation project(":servicetalk-transport-api")
-  implementation project(":servicetalk-transport-netty")
   implementation "com.fasterxml.jackson.core:jackson-core"
   implementation "jakarta.inject:jakarta.inject-api:$actualJavaxInjectVersion"
   implementation "org.glassfish.jersey.core:jersey-server"
   implementation "org.slf4j:slf4j-api:$slf4jVersion"
 
+  runtimeOnly project(":servicetalk-http-router-jersey3-jakarta9")
+
   testImplementation enforcedPlatform("org.junit:junit-bom:$junit5Version")
   testImplementation testFixtures(project(":servicetalk-concurrent-internal"))
   testImplementation testFixtures(project(":servicetalk-http-router-jersey3-jakarta9"))
+  testImplementation project(":servicetalk-buffer-netty")
+  testImplementation project(":servicetalk-http-api")
   testImplementation project(":servicetalk-test-resources")
   testImplementation "org.junit.jupiter:junit-jupiter-api"
   testImplementation "org.junit.jupiter:junit-jupiter-params"

servicetalk-data-jackson-jersey3-jakarta9/gradle.lockfile

@@ -8,22 +8,6 @@ com.fasterxml.jackson:jackson-bom:2.16.2=compileClasspath,runtimeClasspath
 com.google.code.findbugs:jsr305:3.0.2=compileClasspath,runtimeClasspath
 com.sun.activation:jakarta.activation:2.0.1=runtimeClasspath
 com.sun.istack:istack-commons-runtime:4.0.1=runtimeClasspath
-io.netty.incubator:netty-incubator-transport-classes-io_uring:0.0.26.Final=runtimeClasspath
-io.netty.incubator:netty-incubator-transport-native-io_uring:0.0.26.Final=runtimeClasspath
-io.netty:netty-bom:4.1.116.Final=compileClasspath,runtimeClasspath
-io.netty:netty-buffer:4.1.116.Final=compileClasspath,runtimeClasspath
-io.netty:netty-codec:4.1.116.Final=runtimeClasspath
-io.netty:netty-common:4.1.116.Final=compileClasspath,runtimeClasspath
-io.netty:netty-handler:4.1.116.Final=runtimeClasspath
-io.netty:netty-resolver:4.1.116.Final=runtimeClasspath
-io.netty:netty-tcnative-boringssl-static:2.0.69.Final=runtimeClasspath
-io.netty:netty-tcnative-classes:2.0.69.Final=runtimeClasspath
-io.netty:netty-transport-classes-epoll:4.1.116.Final=runtimeClasspath
-io.netty:netty-transport-classes-kqueue:4.1.116.Final=runtimeClasspath
-io.netty:netty-transport-native-epoll:4.1.116.Final=runtimeClasspath
-io.netty:netty-transport-native-kqueue:4.1.116.Final=runtimeClasspath
-io.netty:netty-transport-native-unix-common:4.1.116.Final=runtimeClasspath
-io.netty:netty-transport:4.1.116.Final=runtimeClasspath
 jakarta.annotation:jakarta.annotation-api:2.1.1=compileClasspath,runtimeClasspath
 jakarta.inject:jakarta.inject-api:2.0.1=compileClasspath,runtimeClasspath
 jakarta.validation:jakarta.validation-api:3.0.2=compileClasspath,runtimeClasspath

servicetalk-data-jackson/build.gradle

@@ -27,10 +27,8 @@ dependencies {
   implementation project(":servicetalk-annotations")
   implementation project(":servicetalk-concurrent")
   implementation project(":servicetalk-concurrent-api")
-  implementation project(":servicetalk-concurrent-api-internal")
   implementation project(":servicetalk-concurrent-internal")
   implementation project(":servicetalk-utils-internal")
-  implementation "org.slf4j:slf4j-api:$slf4jVersion"
 
   testImplementation enforcedPlatform("org.junit:junit-bom:$junit5Version")
   testImplementation project(":servicetalk-test-resources")

servicetalk-data-protobuf-jersey/build.gradle

@@ -38,23 +38,20 @@ dependencies {
   implementation platform("com.google.protobuf:protobuf-bom:$protobufVersion")
   implementation project(":servicetalk-annotations")
   implementation project(":servicetalk-buffer-api")
-  implementation project(":servicetalk-buffer-netty")
   implementation project(":servicetalk-concurrent-api")
-  implementation project(":servicetalk-concurrent-api-internal")
   implementation project(":servicetalk-concurrent-internal")
   implementation project(":servicetalk-data-protobuf")
   implementation project(":servicetalk-http-api")
-  implementation project(":servicetalk-http-router-jersey")
   implementation project(":servicetalk-http-router-jersey-internal")
-  implementation project(":servicetalk-http-utils")
   implementation project(":servicetalk-serializer-api")
   implementation project(":servicetalk-transport-api")
-  implementation project(":servicetalk-transport-netty")
   implementation "com.google.protobuf:protobuf-java"
   implementation "org.glassfish.hk2.external:jakarta.inject:$actualJavaxInjectVersion"
   implementation "org.glassfish.jersey.core:jersey-server"
   implementation "org.slf4j:slf4j-api:$slf4jVersion"
 
+  runtimeOnly project(":servicetalk-http-router-jersey")
+
   testImplementation enforcedPlatform("org.junit:junit-bom:$junit5Version")
   testImplementation testFixtures(project(":servicetalk-concurrent-internal"))
   testImplementation testFixtures(project(":servicetalk-http-router-jersey"))

servicetalk-data-protobuf-jersey/gradle.lockfile

@@ -1,32 +1,12 @@
 # This is a Gradle generated file for dependency locking.
 # Manual edits can break the build and are not advised.
 # This file is expected to be part of source control.
-com.fasterxml.jackson.core:jackson-annotations:2.16.2=runtimeClasspath
-com.fasterxml.jackson.core:jackson-core:2.16.2=runtimeClasspath
-com.fasterxml.jackson.core:jackson-databind:2.16.2=runtimeClasspath
-com.fasterxml.jackson:jackson-bom:2.16.2=runtimeClasspath
 com.google.code.findbugs:jsr305:3.0.2=compileClasspath,runtimeClasspath
 com.google.protobuf:protobuf-bom:3.25.3=compileClasspath,runtimeClasspath
 com.google.protobuf:protobuf-java:3.25.3=compileClasspath,runtimeClasspath
 com.sun.activation:jakarta.activation:1.2.2=runtimeClasspath
 com.sun.xml.bind:jaxb-core:2.3.0.1=runtimeClasspath
 com.sun.xml.bind:jaxb-impl:2.3.3=runtimeClasspath
-io.netty.incubator:netty-incubator-transport-classes-io_uring:0.0.26.Final=runtimeClasspath
-io.netty.incubator:netty-incubator-transport-native-io_uring:0.0.26.Final=runtimeClasspath
-io.netty:netty-bom:4.1.116.Final=compileClasspath,runtimeClasspath
-io.netty:netty-buffer:4.1.116.Final=compileClasspath,runtimeClasspath
-io.netty:netty-codec:4.1.116.Final=runtimeClasspath
-io.netty:netty-common:4.1.116.Final=compileClasspath,runtimeClasspath
-io.netty:netty-handler:4.1.116.Final=runtimeClasspath
-io.netty:netty-resolver:4.1.116.Final=runtimeClasspath
-io.netty:netty-tcnative-boringssl-static:2.0.69.Final=runtimeClasspath
-io.netty:netty-tcnative-classes:2.0.69.Final=runtimeClasspath
-io.netty:netty-transport-classes-epoll:4.1.116.Final=runtimeClasspath
-io.netty:netty-transport-classes-kqueue:4.1.116.Final=runtimeClasspath
-io.netty:netty-transport-native-epoll:4.1.116.Final=runtimeClasspath
-io.netty:netty-transport-native-kqueue:4.1.116.Final=runtimeClasspath
-io.netty:netty-transport-native-unix-common:4.1.116.Final=runtimeClasspath
-io.netty:netty-transport:4.1.116.Final=runtimeClasspath
 jakarta.activation:jakarta.activation-api:1.2.2=runtimeClasspath
 jakarta.annotation:jakarta.annotation-api:1.3.5=compileClasspath,runtimeClasspath
 jakarta.validation:jakarta.validation-api:2.0.2=compileClasspath,runtimeClasspath

servicetalk-data-protobuf-jersey3-jakarta10/build.gradle

@@ -99,23 +99,20 @@ dependencies {
   implementation platform("com.google.protobuf:protobuf-bom:$protobufVersion")
   implementation project(":servicetalk-annotations")
   implementation project(":servicetalk-buffer-api")
-  implementation project(":servicetalk-buffer-netty")
   implementation project(":servicetalk-concurrent-api")
-  implementation project(":servicetalk-concurrent-api-internal")
   implementation project(":servicetalk-concurrent-internal")
   implementation project(":servicetalk-data-protobuf")
   implementation project(":servicetalk-http-api")
-  implementation project(":servicetalk-http-router-jersey3-jakarta10")
   implementation project(":servicetalk-http-router-jersey3-jakarta10-internal")
-  implementation project(":servicetalk-http-utils")
   implementation project(":servicetalk-serializer-api")
   implementation project(":servicetalk-transport-api")
-  implementation project(":servicetalk-transport-netty")
   implementation "com.google.protobuf:protobuf-java"
   implementation "jakarta.inject:jakarta.inject-api:$actualJavaxInjectVersion"
   implementation "org.glassfish.jersey.core:jersey-server"
   implementation "org.slf4j:slf4j-api:$slf4jVersion"
 
+  runtimeOnly project(":servicetalk-http-router-jersey3-jakarta10")
+
   testImplementation enforcedPlatform("org.junit:junit-bom:$junit5Version")
   testImplementation testFixtures(project(":servicetalk-concurrent-internal"))
   testImplementation testFixtures(project(":servicetalk-http-router-jersey3-jakarta10"))