This repository has been archived by the owner on Oct 16, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 74
DL-179: Support ZStandard Compression #106
Open
khurrumnasimm
wants to merge
1
commit into
apache:master
Choose a base branch
from
khurrumnasimm:kn/zstd
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
79 changes: 79 additions & 0 deletions
79
distributedlog-protocol/src/main/java/org/apache/distributedlog/io/ZstdCompressionCodec.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,79 @@ | ||
/** | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package org.apache.distributedlog.io; | ||
|
||
import com.github.luben.zstd.Zstd; | ||
import com.google.common.base.Stopwatch; | ||
import java.util.Arrays; | ||
import java.util.concurrent.TimeUnit; | ||
import org.apache.bookkeeper.stats.OpStatsLogger; | ||
|
||
/** | ||
* ZStandard Compression Codec. | ||
* | ||
* {@link http://facebook.github.io/zstd/} | ||
*/ | ||
public class ZstdCompressionCodec implements CompressionCodec { | ||
|
||
public ZstdCompressionCodec() {} | ||
|
||
byte[] getOrCopyData(byte[] data, int offset, int length) { | ||
byte[] copyOfData; | ||
if (0 == offset && length == data.length) { | ||
copyOfData = data; | ||
} else { | ||
copyOfData = Arrays.copyOfRange(data, offset, offset + length); | ||
} | ||
return copyOfData; | ||
} | ||
|
||
@Override | ||
public byte[] compress(byte[] data, int offset, int length, OpStatsLogger compressionStat) { | ||
Stopwatch watch = Stopwatch.createStarted(); | ||
// TODO: make the compression level configurable. | ||
byte[] compressed = Zstd.compress(getOrCopyData(data, offset, length), 3); | ||
|
||
compressionStat.registerSuccessfulEvent(watch.elapsed(TimeUnit.MICROSECONDS)); | ||
return compressed; | ||
} | ||
|
||
@Override | ||
public byte[] decompress(byte[] data, int offset, int length, OpStatsLogger decompressionStat) { | ||
Stopwatch watch = Stopwatch.createStarted(); | ||
byte[] compressedData = getOrCopyData(data, offset, length); | ||
int decompressedSize = (int) Zstd.decompressedSize(compressedData); | ||
byte[] decompressedData = new byte[decompressedSize]; | ||
// TODO: make the compression level configurable. | ||
int actualDecompressedSize = (int) Zstd.decompress(decompressedData, compressedData); | ||
if (actualDecompressedSize != decompressedSize) { | ||
decompressedData = getOrCopyData(decompressedData, 0, actualDecompressedSize); | ||
} | ||
decompressionStat.registerSuccessfulEvent(watch.elapsed(TimeUnit.MICROSECONDS)); | ||
return decompressedData; | ||
} | ||
|
||
@Override | ||
public byte[] decompress(byte[] data, int offset, int length, int decompressedSize, | ||
OpStatsLogger decompressionStat) { | ||
Stopwatch watch = Stopwatch.createStarted(); | ||
// TODO: make the compression level configurable. | ||
byte[] decompressed = Zstd.decompress(getOrCopyData(data, offset, length), decompressedSize); | ||
decompressionStat.registerSuccessfulEvent(watch.elapsed(TimeUnit.MICROSECONDS)); | ||
return decompressed; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
per DL-128, can we try to either tag such TODOs with jira tickets (or just avoid them if not necessary)?