This repository has been archived by the owner on Oct 16, 2024. It is now read-only.
DL-179: Support ZStandard Compression #106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Refer to this link for build results (access rights to CI server needed): |
|
@khurrumnasimm do you have any benchmark results to show performance? it seems we have only 2 bits to tolerant compression algorithm to the record/entry format. I'd like to confirm if the result is promising enough. |
leighst
reviewed
Jan 31, 2017
| byte[] compressedData = getOrCopyData(data, offset, length); | ||
| int decompressedSize = (int) Zstd.decompressedSize(compressedData); | ||
| byte[] decompressedData = new byte[decompressedSize]; | ||
| // TODO: make the compression level configurable. |
There was a problem hiding this comment.
per DL-128, can we try to either tag such TODOs with jira tickets (or just avoid them if not necessary)?
|
It is an interesting work. I will try to pick up this one and carry it forward. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add Zstd compression support.