Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CELEBORN-1824] FlinkShuffleClientImpl should close TransportClient of currentClient #3055

Closed
wants to merge 1 commit into from
Closed

[CELEBORN-1824] FlinkShuffleClientImpl should close TransportClient of currentClient #3055

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .../common/src/main/java/org/apache/celeborn/plugin/flink/client/FlinkShuffleClientImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,10 @@ public void shutdown() {
if (readClientHandler != null) {
readClientHandler.close();
}
for (TransportClient client : currentClient.values()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All transportClient would be closed when invoke flinkTransportClientFactory.close()

client.close();
}
currentClient.clear();
}

public FlinkShuffleClientImpl(
Expand Down Expand Up @@ -685,8 +689,9 @@ private boolean shouldRetry(Throwable e) {
public void cleanup(int shuffleId, int mapId, int attemptId) {
final String mapKey = Utils.makeMapKey(shuffleId, mapId, attemptId);
super.cleanup(shuffleId, mapId, attemptId);
if (currentClient != null) {
currentClient.remove(mapKey);
TransportClient client = currentClient.remove(mapKey);
if (client != null) {
client.close();
}
}

Expand Down
Loading