[CELEBORN-1824] FlinkShuffleClientImpl should close TransportClient of currentClient #3055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteNicholas
force-pushed
the
CELEBORN-1824
branch
from
5a56213 to
db264d6
Compare
RexXiong
reviewed
Jan 7, 2025
| @@ -160,6 +160,10 @@ public void shutdown() { | |||
| if (readClientHandler != null) { | |||
| readClientHandler.close(); | |||
| } | |||
| for (TransportClient client : currentClient.values()) { | |||
There was a problem hiding this comment.
All transportClient would be closed when invoke flinkTransportClientFactory.close()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
FlinkShuffleClientImplclosesTransportClientofcurrentClient.Why are the changes needed?
FlinkShuffleClientImpldoes not closeTransportClientofcurrentClientforcleanupandshutdown. Therefore,FlinkShuffleClientImplshould closeTransportClientofcurrentClient.Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI.