-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fetch_access_token_for_cluster
in EKS hook
#45469
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any way to unit test this edge case of switching regions/accounts like that?
Looks like some of the existing tests need updating first as well |
Does this fix solve #45368 ? |
Oh yeah! I did not know there was a ticket for it. I updated the description to mention it |
This reverts commit dc3111a.
* Revert "Fix the way to get STS endpoint in EKS hook (apache#45520)" This reverts commit 103df61. * Revert "Fix `fetch_access_token_for_cluster` in EKS hook (apache#45469)" This reverts commit dc3111a.
* Revert "Fix the way to get STS endpoint in EKS hook (apache#45520)" This reverts commit 103df61. * Revert "Fix `fetch_access_token_for_cluster` in EKS hook (apache#45469)" This reverts commit dc3111a.
* Revert "Fix the way to get STS endpoint in EKS hook (apache#45520)" This reverts commit 103df61. * Revert "Fix `fetch_access_token_for_cluster` in EKS hook (apache#45469)" This reverts commit dc3111a.
Resolves #45368.
Some users in China reported an issue when integrating EKS with Airflow. The customer could not use the workflow under global account after migrating it to China. Their dag script to connect to EKS cluster using
EksPodOperator
returned 401 .Error:
The root cause is the address to access STS here points to the global address, not the China STS service address. So the eks token obtained cannot be used in China. The sts_url that should be used in China is
https://sts/.{session.region_name}.[amazonaws.com.cn/?Action=GetCallerIdentity&Version=2011-06-15
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.