Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the way to get STS endpoint in EKS hook #45520

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

vincbeck
Copy link
Contributor

@vincbeck vincbeck commented Jan 9, 2025

#45469 introduced a bug and made EKS system test executions fail. The way to get the STS Boto3 client was wrong, instead we should use the hook in order to do that.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:amazon AWS/Amazon - related issues labels Jan 9, 2025
@vincbeck vincbeck merged commit 103df61 into apache:main Jan 9, 2025
60 checks passed
@vincbeck vincbeck deleted the vincbeck/eks-fix branch January 9, 2025 18:20
vincbeck added a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Jan 9, 2025
potiuk pushed a commit that referenced this pull request Jan 9, 2025
* Revert "Fix the way to get STS endpoint in EKS hook (#45520)"

This reverts commit 103df61.

* Revert "Fix `fetch_access_token_for_cluster` in EKS hook (#45469)"

This reverts commit dc3111a.
agupta01 pushed a commit to agupta01/airflow that referenced this pull request Jan 13, 2025
agupta01 pushed a commit to agupta01/airflow that referenced this pull request Jan 13, 2025
* Revert "Fix the way to get STS endpoint in EKS hook (apache#45520)"

This reverts commit 103df61.

* Revert "Fix `fetch_access_token_for_cluster` in EKS hook (apache#45469)"

This reverts commit dc3111a.
karenbraganz pushed a commit to karenbraganz/airflow that referenced this pull request Jan 13, 2025
karenbraganz pushed a commit to karenbraganz/airflow that referenced this pull request Jan 13, 2025
* Revert "Fix the way to get STS endpoint in EKS hook (apache#45520)"

This reverts commit 103df61.

* Revert "Fix `fetch_access_token_for_cluster` in EKS hook (apache#45469)"

This reverts commit dc3111a.
HariGS-DB pushed a commit to HariGS-DB/airflow that referenced this pull request Jan 16, 2025
HariGS-DB pushed a commit to HariGS-DB/airflow that referenced this pull request Jan 16, 2025
* Revert "Fix the way to get STS endpoint in EKS hook (apache#45520)"

This reverts commit 103df61.

* Revert "Fix `fetch_access_token_for_cluster` in EKS hook (apache#45469)"

This reverts commit dc3111a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:amazon AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants