-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the way to get STS endpoint in EKS hook #45520
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
AWS/Amazon - related issues
labels
Jan 9, 2025
vincbeck
force-pushed
the
vincbeck/eks-fix
branch
from
January 9, 2025 17:48
89dae7f
to
d32894e
Compare
hussein-awala
approved these changes
Jan 9, 2025
ferruzzi
approved these changes
Jan 9, 2025
vincbeck
added a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jan 9, 2025
This reverts commit 103df61.
potiuk
pushed a commit
that referenced
this pull request
Jan 9, 2025
agupta01
pushed a commit
to agupta01/airflow
that referenced
this pull request
Jan 13, 2025
agupta01
pushed a commit
to agupta01/airflow
that referenced
this pull request
Jan 13, 2025
* Revert "Fix the way to get STS endpoint in EKS hook (apache#45520)" This reverts commit 103df61. * Revert "Fix `fetch_access_token_for_cluster` in EKS hook (apache#45469)" This reverts commit dc3111a.
karenbraganz
pushed a commit
to karenbraganz/airflow
that referenced
this pull request
Jan 13, 2025
karenbraganz
pushed a commit
to karenbraganz/airflow
that referenced
this pull request
Jan 13, 2025
* Revert "Fix the way to get STS endpoint in EKS hook (apache#45520)" This reverts commit 103df61. * Revert "Fix `fetch_access_token_for_cluster` in EKS hook (apache#45469)" This reverts commit dc3111a.
HariGS-DB
pushed a commit
to HariGS-DB/airflow
that referenced
this pull request
Jan 16, 2025
HariGS-DB
pushed a commit
to HariGS-DB/airflow
that referenced
this pull request
Jan 16, 2025
* Revert "Fix the way to get STS endpoint in EKS hook (apache#45520)" This reverts commit 103df61. * Revert "Fix `fetch_access_token_for_cluster` in EKS hook (apache#45469)" This reverts commit dc3111a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#45469 introduced a bug and made EKS system test executions fail. The way to get the STS Boto3 client was wrong, instead we should use the hook in order to do that.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.