Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nvm #4331

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −13
Open

Remove nvm #4331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,16 +162,3 @@ RUN \
RUN \
service postgresql start \
&& su - postgres -c "psql -c \"alter user postgres with password 'postgres';\""


ENV NODE_VERSION=20.10.0
ENV NVM_VERSION=0.39.7

RUN \
echo "Installing NVM & Node" \
&& curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v${NVM_VERSION}/install.sh | bash \
&& source ~/.nvm/nvm.sh \
&& nvm install $NODE_VERSION \
&& npm install -g [email protected]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have squawk-cli installed here for running the lint-migrations PR check, so do still need it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for highlighting this. Installing squawk-cli via pip.


ENV PATH=/root/.nvm/versions/node/v${NODE_VERSION}/bin:$PATH
1 change: 1 addition & 0 deletions requirements_for_test.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@ flaky==3.8.0
moto==5.0.11
pytest-httpserver==1.0.8
trustme==0.9.0
squawk-cli==1.4.0
2 changes: 2 additions & 0 deletions requirements_for_test.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,8 @@ sqlalchemy==1.4.41
# alembic
# flask-sqlalchemy
# marshmallow-sqlalchemy
squawk-cli==1.4.0
# via -r requirements_for_test.in
statsd==4.0.1
# via
# -r requirements.txt
Expand Down