Remove nvm #4331
Open
Remove nvm #4331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klssmith
reviewed
Jan 9, 2025
| && curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v${NVM_VERSION}/install.sh | bash \ | ||
| && source ~/.nvm/nvm.sh \ | ||
| && nvm install $NODE_VERSION \ | ||
| && npm install -g [email protected] |
There was a problem hiding this comment.
We have squawk-cli installed here for running the lint-migrations PR check, so do still need it
There was a problem hiding this comment.
Thank you for highlighting this. Installing squawk-cli via pip.
spatel033
force-pushed
the
remove-nvm
branch
2 times, most recently
from
169f65c to
53638ed
Compare
As part of ITHC report removing nvm.sh installation. For API nvm is used to install `squawk-cli` so now installing `squawk-cli` via pip and removing nvm.
klssmith
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change is part of the removing nvm as part of ITHC report. More details on this card. We use node only for
squawk-cliso removing the installation via npm and installing via pip/uv.squawk-migration-check has been successful with this change.
