[DO NOT MERGE] Upgrade govuk_publishing_components #1305
Conversation
andysellick
force-pushed
the
fe-fixes
branch
from
7195731 to
6ba91a4
Compare
- should make the govuk_publishing_components guide available at /component-guide
- remove reliance on GOV.UK Elements - set legacy palette to false as deprecated in latest govuk-frontend - temporarily remove overrides and DGU component styles
- use component for header - move GA code into partial - use component for phase banner and add text/link - use govuk-frontend grid layout
- upgrade to last version before the more complex switch to govuk-frontend v5 - update manifest files and Sass to compile all CSS into one file - remove print stylesheet as no longer relevant - update Sass variables/mixins for newer govuk-frontend
- update en.yml to allow iteration
- no longer needed
- used by Rails to detect older IE - no longer needed
|
@andysellick Are you still working on this? |
|
@AgaDufrat not actively for a while now (hence all the conflicts) although it's something I'd like to see through. It really needs a review at this point to assess how much work is still to do - I'm fairly sure there's pages or variations of pages in this app that I can't see locally. |
|
Thanks, for the update. We ported the app from OpenSearch to Solr database and as a result views changed slightly. This is the main diff: https://github.com/alphagov/datagovuk_find/pull/1389/files#diff-115a3524a404227caff1389a9e2619c66f209e8eb5357206beffc48cc90dadeb |
|
@AgaDufrat I tried to rebase this PR but the changes are too extensive and I don't have a locally running system to check them against anymore. I don't have any capacity to work on this now and need to focus on my team work but if there's any code in here that you would find useful feel free to use it. |
What
Update
govuk_publishing_componentsto a newer version, and make related frontend improvements, use newer components, etc.Based on work previously done in #1123
Why
Visual changes
Many! To be added.
Trello card: https://trello.com/c/kL8Aq73n/327-upgrade-dgus-frontend