Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: inview.js to use IntersectionObserver #579

Merged
merged 5 commits into from
Oct 1, 2024
Merged

Update: inview.js to use IntersectionObserver #579

merged 5 commits into from
Oct 1, 2024

Conversation

oliverfoster
Copy link
Member

fixes #578

Update

Refs:

Note:

  • Not ie11 compatible

@oliverfoster oliverfoster self-assigned this Sep 4, 2024
@oliverfoster oliverfoster added the enhancement New feature or request label Sep 4, 2024
@oliverfoster
Copy link
Member Author

Ready now, apologies

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

joe-allen-89
joe-allen-89 approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with bookmarking on chrome, firefox and edge, all working as expected 👍

@oliverfoster oliverfoster merged commit 315f0d1 into master Oct 1, 2024
@oliverfoster oliverfoster deleted the issue/578 branch October 1, 2024 14:18
github-actions bot pushed a commit that referenced this pull request Oct 1, 2024
@semantic-release-bot
Chore(release): 6.55.0
11434ab 
# [6.55.0](v6.54.0...v6.55.0) (2024-10-01)

### Update

* inview.js to use IntersectionObserver (#579) ([315f0d1](315f0d1)), closes [#579](#579)
@oliverfoster
Copy link
Member Author

🎉 This PR is included in version 6.55.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@swashbuck swashbuck mentioned this pull request Oct 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@StuartNicholls StuartNicholls StuartNicholls approved these changes

Assignees

@oliverfoster oliverfoster

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

inview update to use IntersectionObserver instead of manual calculations
4 participants
@oliverfoster @StuartNicholls @cahirodoherty-learningpool @joe-allen-89