Update: inview.js to use IntersectionObserver (#579)

adaptlearning · Oct 1, 2024 · 315f0d1 · 315f0d1
1 parent aaca7c2
commit 315f0d1
Show file tree

Hide file tree

Showing 3 changed files with 284 additions and 544 deletions.
diff --git a/js/views/contentObjectView.js b/js/views/contentObjectView.js
@@ -74,19 +74,18 @@ export default class ContentObjectView extends AdaptView {
         $(window).scrollTop(0);
       }
       Adapt.trigger(`${type}View:ready contentObjectView:ready view:ready`, this);
-      $.inview.unlock(`${type}View`);
       const styleOptions = { opacity: 1 };
       if (this.disableAnimation) {
         this.$el.css(styleOptions);
-        $.inview();
+        $.inview.unlock(`${type}View`);
         _.defer(() => {
           Adapt.trigger(`${type}View:postReady contentObjectView:postReady view:postReady`, this);
         });
       } else {
         this.$el.velocity(styleOptions, {
           duration: 'fast',
           complete: () => {
-            $.inview();
+            $.inview.unlock(`${type}View`);
             Adapt.trigger(`${type}View:postReady contentObjectView:postReady view:postReady`, this);
           }
         });

diff --git a/js/views/notifyPopupView.js b/js/views/notifyPopupView.js
@@ -165,7 +165,6 @@ export default class NotifyPopupView extends Backbone.View {
   }
 
   onOpened() {
-    $.inview();
     this.hasOpened = true;
     // Allows popup manager to control focus
     a11y.popupOpened(this.$el);