ref: simplify matrix interface #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
niermann999
force-pushed
the
ref-simplify-error-messages
branch
from
978af64 to
09f3b5c
Compare
Closed
niermann999
force-pushed
the
ref-simplify-error-messages
branch
from
09f3b5c to
e3e3ff2
Compare
niermann999
force-pushed
the
ref-simplify-error-messages
branch
25 times, most recently
from
eba39c2 to
9dbee43
Compare
niermann999
force-pushed
the
ref-simplify-error-messages
branch
10 times, most recently
from
ec87029 to
c7c9e73
Compare
Merged
niermann999
force-pushed
the
ref-simplify-error-messages
branch
2 times, most recently
from
ca95a64 to
af70ff8
Compare
|
stephenswat
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the matrix interface less verbose and similar to the way we deal with vectors. This is done by adding type traits, which in a later PR will be developed into concepts that can also be used by downstream projects to constrain their template parameters. The templating on many classes has been simplified, because the index type, value type etc can now be associated to a matrix type using the new type traits.
The choice of matrix algorithm (determinant, inverse etc) is done by template specialization, which is a language feature, instead of doing custom metaprogramming.
Also adds the matrix transpose operation to the benchmark suite