feat: generic plugin #131
Merged
feat: generic plugin #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
niermann999
force-pushed
the
feat-generic-plugin2
branch
18 times, most recently
from
65850f1 to
4df06d2
Compare
niermann999
force-pushed
the
feat-generic-plugin2
branch
4 times, most recently
from
8cc979c to
d1c856f
Compare
|
Is this ready for review? And if so - any guidelines on how to do this? In other words, are there any major changes here or is it mostly renaming stuff? |
Yes, I think a lot of it is renaming and moving code around. The getters, for example, were moved into their own files to be able to combine them with different matrix implementations |
niermann999
force-pushed
the
feat-generic-plugin2
branch
from
d1c856f to
44706b9
Compare
|
stephenswat
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cmath frontend cannot be used generically with every linear algebra library, since the subscript operator is not always available. In the current matrix algorithm implementation, a more generic solution is being used by applying the element getter instead. In this PR, this was generalized into a generic implementation, which can be used on top of every linear algebra plugin. The cmath, which relies on the c-style access to arrays, implementation is kept as well, since it is still shared between the
arrayandvecmemplugins.