Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed Default Shortcut Icon to Offline Icon #436

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Changed Default Shortcut Icon to Offline Icon #436

wants to merge 1 commit into from

Conversation

Thunder-Blaze
Copy link
Contributor

Description

  • Made the icon fallback to offline.svg when it is not found
  • Tried to do the same with bookmarks but limit reached ☠️

Related Issues

Preview

image

@prem-k-r
Copy link
Collaborator

prem-k-r commented Jan 5, 2025

Isn't proxy server https://cors-anywhere.herokuapp.com/ have restrictions/limitations?

@Thunder-Blaze
Copy link
Contributor Author

that's what I'm saying
shortcuts are not many so It probably won't reach limit
but when used for bookmark, it reaches the limit easily
It was the only feasible soln I reached at
other solns require having a server run application like react, etc

Either we have to create our own proxy or make do with this

Why does CORS have to come in the way every time 😢

prem-k-r
prem-k-r reviewed Jan 5, 2025
View reviewed changes
style.css
@@ -675,7 +675,7 @@ body #bookmarkButton.bookmark-button.rotate {
color: var(--darkColor-blue);
width: 60px;
font-size: 12px;
padding: 2px 0;
padding: 2px 0 0 0;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
not vertically centered anymore

prem-k-r
prem-k-r requested changes Jan 5, 2025
View reviewed changes
Copy link
Collaborator

@prem-k-r prem-k-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not working for me
image

@prem-k-r
Copy link
Collaborator

prem-k-r commented Jan 5, 2025

image
have to take temp access then it works but, isn't temporary

@Thunder-Blaze Thunder-Blaze marked this pull request as draft January 5, 2025 11:54
@prem-k-r
Copy link
Collaborator

prem-k-r commented Jan 8, 2025

umm, can we use proxy that we are using for search suggestions
https://mynt-proxy.rhythmcorehq.com

@prem-k-r
Copy link
Collaborator

prem-k-r commented Jan 8, 2025

it's not urgent, you can check this out later :)

@Thunder-Blaze
Copy link
Contributor Author

umm, can we use proxy that we are using for search suggestions https://mynt-proxy.rhythmcorehq.com

I'll give it a try
I think it should work

@prem-k-r
Copy link
Collaborator

prem-k-r commented Jan 8, 2025

Ah, it might stop privacy concern users.. may not be a good idea to use proxy server

@prem-k-r prem-k-r linked an issue Jan 9, 2025 that may be closed by this pull request
Missing Shortcut Favicon Error #434
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prem-k-r prem-k-r prem-k-r requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Shortcut Favicon Error
2 participants
@Thunder-Blaze @prem-k-r