Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Shortcut Favicon Error #434

Open
prem-k-r opened this issue Jan 4, 2025 · 1 comment · May be fixed by #436
Open

Missing Shortcut Favicon Error #434

prem-k-r opened this issue Jan 4, 2025 · 1 comment · May be fixed by #436
Labels
bug Something isn't working

Comments

@prem-k-r
Copy link
Collaborator

prem-k-r commented Jan 4, 2025

When adding a shortcut with a URL that lacks a favicon (e.g., invalid websites with correct syntax or valid websites without a favicon), the resulting 404 error causes an overflow, affecting the weather data display.

example: https://xengshi.github.io/materialYouNewTab

image
@prem-k-r prem-k-r added the bug Something isn't working label Jan 4, 2025
@prem-k-r
Copy link
Collaborator Author

prem-k-r commented Jan 4, 2025

Nobody has raised this issue, so I did, hoping someone else can fix it.
I think it requires significant code refactoring.

@Thunder-Blaze Thunder-Blaze linked a pull request Jan 5, 2025 that will close this issue
Draft
@prem-k-r prem-k-r linked a pull request Jan 9, 2025 that will close this issue
Changed Default Shortcut Icon to Offline Icon #436
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changed Default Shortcut Icon to Offline Icon Thunder-Blaze/MaterialYou-NewTab
1 participant
@prem-k-r