Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more flexible SUITE_RUNNER_LOOKUP #438

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Add more flexible SUITE_RUNNER_LOOKUP #438

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc49065
add summy suite runner classes
camillobruni Oct 22, 2024
1ce36c6
remove stub AsyncSuiteRunner
camillobruni Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion resources/benchmark-runner.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,8 @@ export class BenchmarkRunner {
async runSuite(suite) {
// FIXME: Encapsulate more state in the SuiteRunner.
// FIXME: Return and use measured values from SuiteRunner.
const suiteRunner = new SuiteRunner(this._measuredValues, this._frame, this._page, this._client, suite);
const suiteRunnerClass = SUITE_RUNNER_LOOKUP[suite.type ?? "default"];
const suiteRunner = new suiteRunnerClass(this._measuredValues, this._frame, this._page, this._client, suite);
await suiteRunner.run();
}

Expand Down Expand Up @@ -663,3 +664,16 @@ export class SuiteRunner {
await this._client.didRunTest(suite, test);
}
}

// FIXME: implement async steps
class AsyncSuiteRunner extends SuiteRunner {}
camillobruni marked this conversation as resolved.
Show resolved Hide resolved

// FIXME: implement remote steps
class RemoteSuiteRunner extends SuiteRunner {}

const SUITE_RUNNER_LOOKUP = {
__proto__: null,
default: SuiteRunner,
async: AsyncSuiteRunner,
remote: RemoteSuiteRunner,
};
Loading