Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more flexible SUITE_RUNNER_LOOKUP #438

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Add more flexible SUITE_RUNNER_LOOKUP #438

merged 2 commits into from
Nov 13, 2024

Conversation

camillobruni
Copy link
Contributor

  • Add SUITE_RUNNER_LOOKUP to dynamically look up the suite runner class
  • Add dummy AsyncSuiteRunner and RemoteSuiteRunner classes

@camillobruni camillobruni requested a review from julienw October 22, 2024 15:39
flashdesignory
flashdesignory approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@flashdesignory flashdesignory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bgrins
Copy link
Contributor

bgrins commented Nov 11, 2024

Looks like this can merge now

@camillobruni camillobruni merged commit e70778f into WebKit:main Nov 13, 2024
4 checks passed
@camillobruni camillobruni deleted the 2024-10-22_suite_class_lookup branch November 13, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rniwa rniwa rniwa left review comments

@julienw julienw julienw approved these changes

@flashdesignory flashdesignory flashdesignory approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@camillobruni @bgrins @rniwa @flashdesignory @julienw