refactor: polyfill zlib #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following https://github.com/Pomax/lib-font/#how-do-i-use-this-with-webpack I was looking to where Webpack is used, given that the only reference is Vue here. But its vue.config.js has a webpackConfig property, so I followed a hunch… Signed-off-by: André Jaenisch <[email protected]>
This is tweaking the webpack config a little to allow for a comparison. Signed-off-by: André Jaenisch <[email protected]>
Ryuno-Ki
force-pushed
the
zlib-pollyfilled
branch
from
e26b0c1 to
cdc53e0
Compare
|
I prefer to have a choice :) |
It worked on my machine! Signed-off-by: André Jaenisch <[email protected]>
A classic! 😆 Thanks @Ryuno-Ki All these green checkmarks are putting me in a good mood! |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is tweaking the webpack config a little to allow for a comparison.
See also #184.
Signed-off-by: André Jaenisch [email protected]