Trying to fix CI for #185 #187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were two options on how to handle this. The chosen one pleases the linter. Signed-off-by: André Jaenisch <[email protected]>
Following https://github.com/Pomax/lib-font/#how-do-i-use-this-with-webpack I was looking to where Webpack is used, given that the only reference is Vue here. But its vue.config.js has a webpackConfig property, so I followed a hunch… Signed-off-by: André Jaenisch <[email protected]>
This is tweaking the webpack config a little to allow for a comparison. Signed-off-by: André Jaenisch <[email protected]>
|
Okay, now the error is for missing Fingers crossed! |
|
Can you rebase? I believe to have catched this in #185. |
|
@Ryuno-Ki I think we can delete this. I was editing the lockfile directly in an attempt to get something working, but this doesn't look like the way to go. I'll try to upgrade Node and restart this quest in another PR! |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #185
Changing the
package-lock.jsonto fetch fromhttpsinstead ofssh, since the repos are now public.