Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduction.md: Add links to resources. #29327

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

introduction.md: Add links to resources. #29327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion intermediate_html_css/intermediate_html_concepts/introduction.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,11 @@ You'll learn about animations, accessibility, and responsive design in the secon

This section contains helpful links to related content. It isn't required, so consider it supplemental.

- It looks like this lesson doesn't have any additional resources yet. Help us expand this section by contributing to our curriculum.
- [W3Schools HTML Tutorial](https://www.w3schools.com/html/)
Note: Online tutorial.
- [W3Schools CSS Tutorial](https://www.w3schools.com/css/)
Note: Online tutorial.
- [MDN Web Docs](https://developer.mozilla.org/en-US/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't name this as a tutorial. I would change it to "HTML documentation" instead of "Online tutorial". Just so it's a bit clearer.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, it is my first time contributing to an open-source project. I agree that the "MDN Web Docs" is not an online tutorial and should be changed to something like "Documentation for HTML". However, if we clicked on the first 2 links to W3Schools, we would see the term "tutorial" on both sites. So should I also change them to "HTML Documentation" and "CSS Documentation", respectively, as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We wouldn't really need the notes, IMHO. The link text labels, when amended accordingly, should be sufficient by themselves (the current formatting of the Note: line would trigger lint errors anyway, and isn't like how any other additional resources are formatted in the curriculum).

Note: Online tutorial.
- [Learning Web Design A Beginner's Guide to HTML, CSS, JavaScript, and Web Graphics](https://wtf.tw/ref/robbins.pdf)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at it's a pretty long book. I would see this as more of an end of the intermediate section type of resource. If you could remove the book and address the other note I would be happy to merge it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'd be happy to do that.

Note: Comprehensive book on web design (jump ahead to Part II: **HTML MARKUP FOR STRUCTURE** and Part III: **CSS FOR PRESENTATION**).
Loading